Repository navigation
chore: remove abandoned Evidence UI and deploy topology - #36
Conversation
The custom Vite Evidence UI (ui/, served at :5173) was superseded by the forked TrueForge UI with native SchemaForge evidence tabs. Remove: - ui/ — the entire custom Evidence UI app (Vite/React source, tests) - deploy/ — Cloudflare Worker + containers topology that served the Evidence UI SPA from ui/dist - scripts/apply-cf-secrets.sh + scripts/register_deployed.py — the Cloudflare deploy bootstrap flow - packages/cli: DIST/MIME static-serving remnants in schemaforge.js, ui-dist/ from files + build script, UI build step in prepack.mjs - .env.example Cloudflare deployment block, .gitignore ui-dist entry The CLI's :5173 server stays as a pure config proxy + redirect to the TrueForge UI. READMEs now describe the TrueForge UI (SchemaForge evidence tabs + Settings) as the interface.
PR Summary by QodoRemove abandoned Evidence UI and Cloudflare deployment
AI Description
Diagram
High-Level Assessment
Files changed (9)
|
Code Review by Qodo
1.
|
Qodo review (PR #36) surfaced two gaps in the Evidence-UI removal: 1. npx users boot the stock @truefoundry/trueforge UI and nothing patched in mermaid rendering — the README claimed graphs render in chat. 2. The documented manual command (python scripts/patch-trueforge-mermaid.py) assumed a repo checkout; a consumer cwd has no scripts/ dir. The CLI now runs the patch automatically after TrueForge comes up (retrying until the npx _frontend exists; non-fatal), and the patch script discovers the npx cache path dynamically instead of hardcoding a machine-specific hash. READMEs scope the SchemaForge evidence tabs to this workspace's forked TrueForge UI and state the stock-UI behavior for the published package.
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit d0a674d |
Qodo re-review (PR #36) surfaced three regressions in the auto-patch: 1. patchTrueForgeUi ran the host python3, which lacks httpx (it lives in the provisioned venv) — every attempt died at import on clean hosts. Now prefers venvPy and falls back to py. 2. The patch script picked the newest npx cache entry by mtime, which can differ from the TrueForge the CLI actually launched/reused (an npx re-fetch creates a new cache entry while an older one still serves). Now patches EVERY npx-cached @truefoundry/trueforge _frontend — idempotent and always covers the served one. 3. READMEs told npx consumers to run 'python scripts/...' from their cwd, which has no scripts/ dir. The CLI patches on every launch, so the manual re-run instructions are dropped.
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 4b37c83 |
Qodo round 3 (PR #36): discover_frontends() hardcoded ~/.npm/_npx, which misses Windows and custom npm-cache setups (npm config get cache), and patching one entry left the served copy ambiguous. Now: - npm cache resolved via 'npm config get cache' with ~/.npm fallback - all discovered @truefoundry/trueforge _frontends patched (idempotent) - SF_TF_FRONTEND env var pins the exact frontend when the caller knows it
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit fbff7b9 |
…tch) Qodo round 4 (PR #36): the README still led with the SchemaForge evidence tabs as the interface, but the published package launches the stock @truefoundry/trueforge UI and only patches mermaid rendering — the tabs live in the dev-workspace fork (trueforge-ui-fork), which the package does not bundle. Reorder both READMEs so the shipped behavior (stock chat UI, auto mermaid patch, per-session artifacts downloadable from chat, stock four-section Settings) is the primary claim, with the fork's evidence tabs + SchemaForge Settings section described as a dev-workspace variant.
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 3b4560e |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 3b4560e |
Removes the custom Vite Evidence UI (
ui/), its Cloudflare deploy topology (deploy/,apply-cf-secrets.sh,register_deployed.py), and the static-serving remnants in the CLI.Shipped behavior after this PR (matches what a fresh
npx @schemaforge/schemaforgeuser gets): the CLI boots TrueForge + MCP servers + registry, opens the stock TrueForge chat UI at[::1]:8790, and patches the served frontend on every launch so mermaid impact graphs render inside chat. Evidence artifacts are saved per session in the sandbox and downloadable from chat. The:5173server remains as a config proxy + redirect to the TrueForge UI.Dev workspace only (
trueforge-ui-fork, not bundled by the npm package): a forked TrueForge UI adds SchemaForge evidence tabs (Impact/Report/Changes/Verification/Activity) and a SchemaForge Settings section.ui/deleted (57 tracked files, −13.7k lines) — superseded by the fork tabsdeploy/deleted — Worker existed to serve the Evidence UI SPA fromui/distpackages/cli/bin/schemaforge.js: droppedDIST/static-serving; added auto mermaid patch on launch (venv python, retries, all npx cache frontends,SF_TF_FRONTENDpin)packages/cli/package.json+prepack.mjs: no longer build/bundleui/scripts/patch-trueforge-mermaid.py: npm-cache-aware discovery, patches every npx copyREADME.md+packages/cli/README.md: shipped behavior described exactly; fork tabs explicitly a dev-workspace variantnode --checkon bin + prepack, patch script rc=0 against the live frontend, noEvidence UI/ui-distreferences in shipped files