Skip to content

Fix cross-platform CI checks - #8

Draft
romainsacchi wants to merge 1 commit into
mainfrom
fix/ci-quality-windows-catalog
Draft

Fix cross-platform CI checks#8
romainsacchi wants to merge 1 commit into
mainfrom
fix/ci-quality-windows-catalog

Conversation

@romainsacchi

Copy link
Copy Markdown
Owner

Summary

  • apply the repository's Black formatting to the two files rejected by the quality job
  • remove one placeholder-free f-string exposed by the now-running Ruff step
  • force LF checkouts for the integrity-manifested SimaPro category CSV so Git on Windows does not change its hash and size

Root cause

The quality job stopped at Black, hiding a Ruff failure in a later step. Separately, .gitattributes forced LF only for JSON resources. Windows therefore checked out the manifested category CSV with CRLF bytes, causing five integrity failures and one downstream missing-category assertion.

Validation

  • black --check brightpath tests docs/conf.py
  • python -m isort --check-only brightpath tests docs/conf.py
  • python -m ruff check brightpath tests docs/conf.py
  • python -m bandit -r brightpath
  • python -m sphinx -W --keep-going -b html docs docs/_build/html
  • pytest -q --cov=brightpath — 398 passed, 3 skipped
  • python -m build
  • autocrlf-enabled staged checkout: pytest -q tests/test_simapro_categories.py — 8 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant