Use ECP launch to start the sideloaded channel#338
Draft
chrisdp wants to merge 2 commits into
Draft
Conversation
Sets `autoLaunch: false` on the sideload so the device installs without launching, then posts `/launch/dev` via ECP to start the channel. When `deepLinkUrl` is set, its query string is appended to the launch call.
After publish with `autoLaunch: false`, poll `query/app-state` until the device reports the dev channel as `inactive` or `background` before firing the ECP launch. Bounded at 10s. Avoids racing the device's install-settle step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roku-deployto3.17.3(adds the newautoLaunchoption, rokucommunity/roku-deploy#261).autoLaunch: falsewhen sideloading so the device does not auto-launch the channel.launch/devvia ECP after the sideload completes. IfdeepLinkUrlis set, its query string is appended to that launch call so the channel sees the deep link in its initial launch args.rokuECP.launchApp({ channelId, params? }).paramsaccepts a full URL, a leading-?query string, or a rawkey=valuequery string.Test plan
npm run test:nocover(the two remainingBreakpointManagerfailures are unrelated, pre-existing on master)rokuECP.launchAppand the publish-then-launch flowdeepLinkUrlset