Make sure --dap mode only outputs dap things to stdout

src/FileUtils.spec.ts

@@ -6,6 +6,7 @@ import * as sinonActual from 'sinon';
 import { SourceNode } from 'source-map';
 import { fileUtils, standardizePath as s } from './FileUtils';
 import { SourceMapManager } from './managers/SourceMapManager';
+import { logger } from './logging';
 
 let sinon = sinonActual.createSandbox();
 const rootDir = path.normalize(path.dirname(__dirname));
@@ -78,7 +79,7 @@ describe('FileUtils', () => {
         });
 
         it('returns first result when multiple matches are found', async () => {
-            let stub = sinon.stub(console, 'warn').returns(undefined);
+            let stub = sinon.stub(logger, 'warn').returns(undefined);
 
             expect(await fileUtils.findPartialFileInDirectory('...lib.brs', 'SomeAppDir')).to.equal('source/lib1/lib.brs');
 

src/FileUtils.ts

@@ -4,6 +4,7 @@ import * as glob from 'glob';
 import * as path from 'path';
 import { promisify } from 'util';
 import { util as rokuDeployUtil } from 'roku-deploy';
+import { logger } from './logging';
 const globp = promisify(glob);
 
 export class FileUtils {
@@ -89,7 +90,7 @@ export class FileUtils {
 
         //TODO is there something more we should do about finding multiple matches?
         if (results.length > 1) {
-            console.warn(
+            logger.warn(
                 `Found multiple paths in '${directoryPath}' that match '${partialFilePath}'. Returning the first result, but you should consider renaming files in longer file paths to something unique`
             );
         }

src/RendezvousTracker.ts

@@ -129,7 +129,7 @@ export class RendezvousTracker {
             }
         } catch (e) {
             //if there was an error pinging rendezvous, log the error but don't bring down the app
-            console.error('There was an error fetching rendezvous data', e?.stack);
+            this.logger.error('There was an error fetching rendezvous data', e?.stack);
         }
     }
 

src/SceneGraphDebugCommandController.ts

@@ -292,7 +292,7 @@ export class SceneGraphDebugCommandController {
                 this.removeConnection();
             } catch (error) {
                 this.removeConnection();
-                console.log(error, this.connection);
+                this.logger.error(error, this.connection);
             }
         }
     }

src/adapters/DebugProtocolAdapter.ts

@@ -323,7 +323,7 @@ export class DebugProtocolAdapter {
             });
 
             this.client.on('runtime-error', (data) => {
-                console.debug('hasRuntimeError!!', data);
+                this.logger.debug('hasRuntimeError!!', data);
                 this.emit('runtime-error', <BrightScriptRuntimeError>{
                     message: data.data.stopReasonDetail,
                     errorCode: data.data.stopReason

src/adapters/TelnetRequestPipeline.ts

@@ -302,9 +302,6 @@ export class TelnetCommand {
 
 
     public handleData(pipeline: TelnetRequestPipeline) {
-        if (this.deferred.isCompleted) {
-            console.log('stop here');
-        }
         //get the first response
         const match = /Brightscript Debugger>\s*/is.exec(pipeline.unhandledText);
         if (match) {

src/bsc/threading/WorkerPool.ts

@@ -73,9 +73,9 @@ export class WorkerPool {
     public dispose() {
         for (const worker of this.allWorkers) {
             try {
-                void worker.terminate().catch((e) => console.error(e));
+                void worker.terminate().catch((e) => this.logger.error(e));
             } catch (e) {
-                console.error(e);
+                this.logger.error(e);
             }
         }
         this.allWorkers = [];