Skip to content

Export TFJS/CoreML with fused NMS - #6

Merged
leeclemnet merged 3 commits into
mainfrom
feat/tfjs-coreml-fused-nms
Apr 3, 2026
Merged

leeclemnet merged 3 commits into
mainfrom
feat/tfjs-coreml-fused-nms

Conversation

@leeclemnet

@leeclemnet leeclemnet commented Apr 3, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Bakes in NMS to TFJS and CoreML exports to simplify client-side logic

  • inferencejs client was already using TF NMS, this just brings it inside the model artifact
  • roboflow-swift should use native coreml NMS for best performance

Thresholds for both are configurable at runtime.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
    • This is technically a breaking change but tfjs and coreml exports are not yet usable on platform.

Testing

  • I have tested this change locally
  • I have added/updated tests for this change

Test details:

[internal link removed]

local tfjs inference with nms baked in

[internal link removed]

image

local coreml inference with nms baked in

roboflow/roboflow-swift#27

chess-devcontainer-sdk-annotated

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@leeclemnet leeclemnet changed the title Export TFJS and CoreML with baked-in nms Export ONNX/TFJS/CoreML with fused NMS Apr 3, 2026
@leeclemnet leeclemnet changed the title Export ONNX/TFJS/CoreML with fused NMS Export TFJS/CoreML with fused NMS Apr 3, 2026
@leeclemnet
leeclemnet force-pushed the feat/tfjs-coreml-fused-nms branch from 92036ec to 7d9378c Compare April 3, 2026 18:31
@leeclemnet
leeclemnet marked this pull request as ready for review April 3, 2026 19:14
@leeclemnet
leeclemnet merged commit 201dd3e into main Apr 3, 2026
@leeclemnet
leeclemnet deleted the feat/tfjs-coreml-fused-nms branch April 3, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant