Refactor: Replace silent capability stubs with explicit NotImplementedError failures - #788
Open
magqqgq wants to merge 1 commit into
Open
Refactor: Replace silent capability stubs with explicit NotImplementedError failures#788magqqgq wants to merge 1 commit into
magqqgq wants to merge 1 commit into
Conversation
…dError failures Why The Confluent Kafka transport driver previously contained placeholder stubs for topic creation and partition lookup capabilities that failed silently or lacked explicit interface enforcement. How Replaced unreachable or silent topic/partition capability stubs with explicit NotImplementedError failures across the consumer and producer components. Security/Robustness changes Improves API contract clarity by raising explicit errors when unsupported transport operations are invoked. Testing Verified that the modified Python file compiles cleanly using py_compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Confluent Kafka transport driver previously contained placeholder stubs for topic creation and partition lookup capabilities that failed silently or lacked explicit interface enforcement.
How
Replaced unreachable or silent topic/partition capability stubs with explicit NotImplementedError failures across the consumer and producer components.
Security/Robustness changes
Improves API contract clarity by raising explicit errors when unsupported transport operations are invoked.
Testing
Verified that the modified Python file compiles cleanly using py_compile.