Repository navigation
fix: prevent unparse crash on split surrogate entities - #36
Open
sabbirexist wants to merge 1 commit into
Open
sabbirexist wants to merge 1 commit into
sabbirexist wants to merge 1 commit into
Conversation
Owner
|
Thanks for this. The half-emoji crash is real, and the new tests catch it (7 of them fail on dev and pass on this branch). One case I hit while testing: when two entities overlap after the widening, the Markdown output puts the tags in the wrong order. Examples:
HTML comes out fine for both. Could you add a test for overlapping entities in Markdown and make sure the output stays well formed? Let me know when it's pushed and I'll take another look. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnicodeDecodeErrorin HTML and Markdown unparse when an entity boundary falls inside a UTF-16 surrogate pair.clamp_to_code_point()to safely widen misaligned boundaries to the complete Unicode code point.