Filter out perl from listdeps --omit-core - #739
Merged
Merged
Conversation
Contributor
|
This would be a handy option to use on the PrereqSource role -- when finalizing all prereqs, omit those that are in core as of the minimum required perl version. |
Contributor
|
Looks like someone had that idea as part of their plugin: https://metacpan.org/pod/Dist::Zilla::Plugin::PrereqsClean I think it would make sense as an AutoPrereqs option, but otherwise, prefer to do that determination in my manual prereq specification. (anyway getting a bit off topic for this PR) |
Contributor
|
yeah, filtering it in AutoPrereqs sounds fine. |
Contributor
Author
Yeah, kind of. |
This will filter out perl from listed dependencies when --omit-core satisfies the requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will filter out perl from listed dependencies when --omit-core satisfies the requirement.
E.g. previously
dzil listdeps --json --omit-core=5.042would look something like:that will now look like: