Skip to content

fix(rivetkit): fix BigInt serialization in inspector workflow history and state deserialization #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abcxff wants to merge 1 commit into
base: 05-12-do_not_merge_queue_diagnose
Choose a base branch
from
+20 −4
Draft

fix(rivetkit): fix BigInt serialization in inspector workflow history and state deserialization #5058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ packages:
- scripts/tests
- shared/typescript/*
- website
- ext/*
- website/scripts/typecheck-staging

ignoredBuiltDependencies:
Expand Down
8 changes: 4 additions & 4 deletions rivetkit-typescript/packages/rivetkit/src/registry/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import type {
} from "@/registry/config";
import {
decodeCborCompat,
decodeCborJsonCompat,
encodeCborCompat,
} from "@/serde";
import { getEnvUniversal, VERSION } from "@/utils";
Expand Down Expand Up @@ -594,7 +593,7 @@ function decodeValue<T>(value?: RuntimeBytes | null): T {
return undefined as T;
}

return decodeCborJsonCompat(value);
return decodeCborCompat(value);
}

function encodeValue(value: unknown): RuntimeBytes {
Expand Down Expand Up @@ -931,6 +930,7 @@ function serializeWorkflowEntryKind(
}
}

// TODO: Switch inspector routes to CBOR encoding
function serializeWorkflowHistoryForJson(data: ArrayBuffer | null): {
nameRegistry: string[];
entries: Array<{
Expand Down Expand Up @@ -964,7 +964,7 @@ function serializeWorkflowHistoryForJson(data: ArrayBuffer | null): {

const history = decodeWorkflowHistoryTransport(data);

return {
return jsonSafe({
nameRegistry: [...history.nameRegistry],
entries: history.entries.map((entry) => ({
id: entry.id,
Expand Down Expand Up @@ -994,7 +994,7 @@ function serializeWorkflowHistoryForJson(data: ArrayBuffer | null): {
],
),
),
};
});
}

function toHttpJsonCompatible<T>(value: T): T {
Expand Down
Loading