fix(rivetkit-core): chunk apply_batch puts/deletes at 128#5046
Open
abcxff wants to merge 1 commit into
Conversation
|
🚅 Deployed to the rivet-pr-5046 environment in rivet-frontend
|
This was referenced May 12, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 12, 2026
Contributor
The fix is correct and addresses a real crash path (engine rejects batches > 128 keys). The constant naming and cross-referencing are good. The primary concern is the non-atomicity window introduced by multi-chunk writes — this should be tracked in
|
abcxff
force-pushed
the
05-07-fix_pegboard_validate_drain_grace_period_request_lifespan
branch
from
aac9634 to
f8fe5aa
Compare
abcxff
force-pushed
the
05-12-fix_rivetkit-core_chunk_apply_batch_puts_deletes_at_128
branch
from
7920c6d to
78dd055
Compare
abcxff
force-pushed
the
05-12-fix_rivetkit-core_chunk_apply_batch_puts_deletes_at_128
branch
from
78dd055 to
741181f
Compare
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy of https://app.graphite.com/github/pr/rivet-dev/rivet/5012