temp: patch out broken wasm-pack package#5039
Conversation
|
🚅 Deployed to the rivet-pr-5039 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewOverviewThis PR addresses a broken IssuesThe two changes work against each other The patch in As written, Suggested resolution — pick one approach:
After this change, Observations (non-blocking)
SummaryThe patch itself is correct and worth keeping. The workflow change as written orphans the |
9db09c9 to
1776d42
Compare
PR Review: temp: patch out broken wasm-pack packageOverview: This PR applies a pnpm patch to What the patch doesThe core fix is one line in This is a known upstream issue: the wasm-pack project moved from the Code quality
Concerns1. No upstream tracking reference. Nothing in the patch or 2. Patch maintenance risk. pnpm patches are tied to an exact version. If 3. Version upgrade not explored. If a later SecurityNo concerns. SummaryCorrect and low-risk build-tooling fix. Main gap is lifecycle documentation: add a comment or todo linking to the upstream bug so the patch gets removed once a fixed npm release is available. |
d69dfaa to
5014be8
Compare
1776d42 to
e5051b1
Compare
5014be8 to
6eedbc8
Compare
e5051b1 to
0c2652a
Compare
0c2652a to
be6f05a
Compare
6eedbc8 to
8e1538c
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: