temp: patch wasm-pack to point to latest binary#5037
Conversation
|
PR #5037 Review: temp: patch wasm-pack to point to latest binary Overview: This PR makes two distinct changes: (1) adds a pnpm patch for wasm-pack@0.14.0 that corrects the binary download URL, changing the GitHub author field in binary.js from "drager" to "wasm-bindgen"; and (2) disables the build-wasm CI job entirely and removes wasm artifact steps from the publish job. Issues and Concerns: Binary URL correctness needs verification. The patch redirects binary downloads to github.com/wasm-bindgen/wasm-pack instead of github.com/drager/wasm-pack. Please confirm that wasm-bindgen/wasm-pack is the correct canonical upstream for v0.14.0 releases before merging, and that the binaries can be trusted. Downloading from a potentially wrong repository without checksum verification is a supply-chain risk. Disabling build-wasm is contradictory with the patch. If the patch correctly fixes the wasm-pack download URL, the build-wasm CI job should work after applying it. The PR simultaneously adds a fix and disables the thing the fix is supposed to fix, without explaining why. This suggests there is a separate undocumented reason for disabling the job. Either the patch is sufficient and build-wasm should be re-enabled, or the patch is not enough and the PR description should explain what else is broken. Wasm package will not be published. Removing build-wasm from the publish job needs array means @rivetkit/rivetkit-wasm will not ship in any release while this change is in effect. No fallback is provided for downstream consumers. Incomplete description. The PR is DRAFT, the template is entirely unfilled, and the title has a temp: prefix. The root cause (why does wasm-pack 0.14.0 use the wrong author string?), the relationship between the two changes, and the follow-up plan to re-enable wasm builds should all be documented before merging. Code Quality: The pnpm patch is minimal and correctly structured; using patchedDependencies in package.json is the right mechanism for fixing a third-party package bug. The pnpm-lock.yaml changes are correct and consistent with the patch registration. A brief inline comment in publish.yaml explaining why the job is disabled would help future maintainers. Summary: The patch approach is technically sound, but the PR disables wasm publishing without explaining why the patch alone is not sufficient to restore the build-wasm CI job. The description must be filled in before merging, and the binary URL change should be verified against the canonical wasm-pack upstream to rule out supply-chain risk. |
e872ef5 to
d644728
Compare
d644728 to
abf9ff9
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: