Skip to content

fix(sqlite): quiet startup database miss #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
May 9, 2026
Merged

fix(sqlite): quiet startup database miss #5005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions engine/packages/pegboard-envoy/src/ws_to_tunnel_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,14 +474,22 @@ async fn handle_sqlite_get_pages_response(
match handle_sqlite_get_pages(ctx, conn, request).await {
Ok(response) => response,
Err(err) => {
tracing::error!(
actor_id = %actor_id,
?pgnos,
?expected_generation,
?expected_head_txid,
?err,
"sqlite get_pages request failed"
);
if is_startup_database_miss(&err, expected_generation, expected_head_txid) {
tracing::debug!(
actor_id = %actor_id,
?pgnos,
"sqlite get_pages did not find an existing actor database"
);
} else {
tracing::error!(
actor_id = %actor_id,
?pgnos,
?expected_generation,
?expected_head_txid,
?err,
"sqlite get_pages request failed"
);
}
protocol::SqliteGetPagesResponse::SqliteErrorResponse(sqlite_error_response(&err))
}
}
Expand Down Expand Up @@ -1115,6 +1123,16 @@ fn depot_error(err: &anyhow::Error) -> Option<&SqliteStorageError> {
.find_map(|source| source.downcast_ref::<SqliteStorageError>())
}

fn is_startup_database_miss(
err: &anyhow::Error,
expected_generation: Option<u64>,
expected_head_txid: Option<u64>,
) -> bool {
expected_generation.is_none()
&& expected_head_txid.is_none()
&& matches!(depot_error(err), Some(SqliteStorageError::DatabaseNotFound))
}

fn sqlite_error_reason(err: &anyhow::Error) -> String {
err.chain()
.map(ToString::to_string)
Expand Down
Loading