Skip to content

fix(rivetkit): bind methods through createWriteThroughProxy #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abcxff wants to merge 1 commit into
base: 05-14-fix_rivetkit_revert_remove_client-side_connection_request_size_check
Choose a base branch
from
Open

fix(rivetkit): bind methods through createWriteThroughProxy #4987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 115 additions & 100 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

54 changes: 54 additions & 0 deletions rivetkit-asyncapi/asyncapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,33 @@
"type": "null"
}
]
},
"actor": {
"type": "object",
"properties": {
"actorId": {
"type": "string"
},
"generation": {
"anyOf": [
{
"type": "number"
},
{
"type": "integer",
"format": "int64"
}
]
},
"key": {
"type": "string"
}
},
"required": [
"actorId",
"generation"
],
"additionalProperties": false
}
},
"required": [
Expand Down Expand Up @@ -421,6 +448,33 @@
"type": "null"
}
]
},
"actor": {
"type": "object",
"properties": {
"actorId": {
"type": "string"
},
"generation": {
"anyOf": [
{
"type": "number"
},
{
"type": "integer",
"format": "int64"
}
]
},
"key": {
"type": "string"
}
},
"required": [
"actorId",
"generation"
],
"additionalProperties": false
}
},
"required": [
Expand Down
5 changes: 3 additions & 2 deletions rivetkit-typescript/packages/rivetkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,14 @@
"actor-config-schema-gen": "tsx scripts/actor-config-schema-gen.ts"
},
"dependencies": {
"@rivet-dev/agent-os-core": "^0.1.1",
"@hono/node-server": "^1.18.2",
"@hono/node-ws": "^1.1.1",
"@hono/zod-openapi": "^1.1.5",
"@rivet-dev/agent-os-core": "^0.1.1",
"@rivetkit/bare-ts": "^0.6.2",
"@rivetkit/engine-cli": "workspace:*",
"@rivetkit/engine-envoy-protocol": "workspace:*",
"@rivetkit/on-change": "6.0.1",
"@rivetkit/rivetkit-napi": "workspace:*",
"@rivetkit/rivetkit-wasm": "workspace:*",
"@rivetkit/traces": "workspace:*",
Expand All @@ -192,10 +193,10 @@
"zod": "^4.1.0"
},
"devDependencies": {
"@biomejs/biome": "^2.3",
"@copilotkit/llmock": "^1.6.0",
"@rivet-dev/agent-os-common": "*",
"@rivet-dev/agent-os-pi": "^0.1.1",
"@biomejs/biome": "^2.3",
"@standard-schema/spec": "^1.0.0",
"@types/invariant": "^2",
"@types/node": "^22.13.1",
Expand Down
3 changes: 2 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/client/actor-conn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
import { assertUnreachable, stringifyError } from "@/common/utils";
import type { UniversalWebSocket } from "@/common/websocket-interface";
import type { EngineControlClient } from "@/engine-client/driver";
import type { JsonCompatValue } from "@/common/encoding";
import {
decodeCborCompat,
deserializeWithEncoding,
Expand Down Expand Up @@ -1269,7 +1270,7 @@ export class ActorConnRaw {
name: msg.body.val.name,
args: bufferToArrayBuffer(
encodeCborCompat(
msg.body.val.args,
msg.body.val.args as JsonCompatValue,
),
),
},
Expand Down
3 changes: 2 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/client/actor-handle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
} from "@/common/client-protocol-zod";
import { deconstructError } from "@/common/utils";
import type { EngineControlClient } from "@/engine-client/driver";
import type { JsonCompatValue } from "@/common/encoding";
import { decodeCborCompat, deserializeWithEncoding, encodeCborCompat } from "@/serde";
import { bufferToArrayBuffer } from "@/utils";
import type {
Expand Down Expand Up @@ -332,7 +333,7 @@ export class ActorHandleRaw {
args,
}),
requestToBare: (args): protocol.HttpActionRequest => ({
args: bufferToArrayBuffer(encodeCborCompat(args)),
args: bufferToArrayBuffer(encodeCborCompat(args as JsonCompatValue)),
}),
responseFromJson: (json): Response => json.output as Response,
responseFromBare: (bare): Response =>
Expand Down
3 changes: 2 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/client/queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
type HttpQueueSendResponse as HttpQueueSendResponseJson,
HttpQueueSendResponseSchema,
} from "@/common/client-protocol-zod";
import type { JsonCompatValue } from "@/common/encoding";
import { decodeCborCompat, encodeCborCompat } from "@/serde";
import { bufferToArrayBuffer } from "@/utils";
import { sendHttpRequest } from "./utils";
Expand Down Expand Up @@ -111,7 +112,7 @@ export function createQueueSender(
}),
requestToBare: (value): protocol.HttpQueueSendRequest => ({
name: value.name ?? name,
body: bufferToArrayBuffer(encodeCborCompat(value.body)),
body: bufferToArrayBuffer(encodeCborCompat(value.body as JsonCompatValue)),
wait: value.wait ?? false,
timeout:
value.timeout !== undefined ? BigInt(value.timeout) : null,
Expand Down
Loading
Loading