Skip to content

feat(depot-client): wire sqlite optimization flags #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanFlurry wants to merge 1 commit into from
Closed

feat(depot-client): wire sqlite optimization flags #4923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/packages/depot-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ depot-client-types.workspace = true
depot.workspace = true
moka = { version = "0.12", default-features = false, features = ["sync"] }
parking_lot.workspace = true
scc.workspace = true

[dev-dependencies]
depot = { workspace = true, features = ["test-faults"] }
Expand All @@ -31,7 +32,6 @@ gas.workspace = true
rivet-config.workspace = true
rivet-pools.workspace = true
rivet-test-deps.workspace = true
scc.workspace = true
sha2.workspace = true
tempfile.workspace = true
universaldb.workspace = true
Expand Down
13 changes: 7 additions & 6 deletions engine/packages/depot-client/src/database.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::{
vfs::{
NativeVfsHandle, SqliteTransportHandle, SqliteVfs, SqliteVfsMetrics,
SqliteVfsMetricsSnapshot, VfsConfig, VfsPreloadHintSnapshot,
fetch_initial_main_page_for_registration,
fetch_initial_pages_for_registration,
},
worker::SqliteWorkerHandle,
};
Expand All @@ -32,17 +32,18 @@ pub async fn open_database_from_transport(
metrics: Option<Arc<dyn SqliteVfsMetrics>>,
) -> Result<NativeDatabaseHandle> {
let vfs_name = vfs_name_for_actor_database(&actor_id, generation);
let initial_main_page = fetch_initial_main_page_for_registration(transport.clone(), &actor_id)
let config = VfsConfig::default();
let initial_pages = fetch_initial_pages_for_registration(transport.clone(), &actor_id, &config)
.await
.map_err(|e| anyhow!("failed to preload sqlite main page: {e}"))?;
.map_err(|e| anyhow!("failed to preload sqlite pages: {e}"))?;
let vfs = Arc::new(
SqliteVfs::register_with_transport_and_initial_page(
SqliteVfs::register_with_transport_and_initial_pages(
&vfs_name,
transport,
actor_id.clone(),
rt_handle,
VfsConfig::default(),
initial_main_page,
config,
initial_pages,
metrics.clone(),
)
.map_err(|e| anyhow!("failed to register sqlite VFS: {e}"))?,
Expand Down
Loading
Loading