Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .agent/notes/db-driver-test-rerun-2026-05-03.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# DB Driver Test Rerun 2026-05-03

Config: static registry, bare encoding, native/local plus wasm/remote.

## Results

- [x] actor-db: native/local passed, wasm/remote passed
- [x] actor-db-raw: native/local passed, wasm/remote passed
- [x] actor-db-init-order: native/local passed, wasm/remote passed
- [x] actor-db-pragma-migration: native/local passed, wasm/remote passed
- [x] actor-sleep-db: native/local passed, wasm/remote passed
- [x] actor-db-stress: native/local passed, wasm/remote passed on rerun

## Notes

- Fixed a grace-deadline shutdown bug where SQLite cleanup happened after final state serialization, allowing delayed callbacks from the old generation to issue late DB work.
- Added a shared closed flag to `SqliteDb` so both local and remote SQLite handles fail closed after cleanup.
- The first full wasm/remote stress run hit `ltx trailer checksums must be zeroed` in the kitchen-sink case. The isolated kitchen-sink rerun and the full wasm/remote stress rerun both passed.
508 changes: 508 additions & 0 deletions .agent/notes/sqlite-memory-soak-issues.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions engine/sdks/rust/envoy-client/src/actor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1652,6 +1652,7 @@ mod tests {
envoy_key: "test-envoy".to_string(),
envoy_tx,
actors: Arc::new(std::sync::Mutex::new(HashMap::new())),
actors_notify: Arc::new(tokio::sync::Notify::new()),
live_tunnel_requests: Arc::new(std::sync::Mutex::new(HashMap::new())),
pending_hibernation_restores: Arc::new(std::sync::Mutex::new(HashMap::new())),
ws_tx: Arc::new(tokio::sync::Mutex::new(
Expand Down
4 changes: 3 additions & 1 deletion engine/sdks/rust/envoy-client/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
use std::sync::Arc;
use std::sync::Mutex as StdMutex;
use std::sync::atomic::AtomicBool;

Check warning on line 5 in engine/sdks/rust/envoy-client/src/context.rs

View workflow job for this annotation

GitHub Actions / Rustfmt

Diff in /home/runner/work/rivet/rivet/engine/sdks/rust/envoy-client/src/context.rs

Check warning on line 5 in engine/sdks/rust/envoy-client/src/context.rs

View workflow job for this annotation

GitHub Actions / Rustfmt

Diff in /home/runner/work/rivet/rivet/engine/sdks/rust/envoy-client/src/context.rs
use crate::async_counter::AsyncCounter;
use rivet_envoy_protocol as protocol;
use tokio::sync::Mutex;
use tokio::sync::mpsc;
use tokio::sync::Mutex;
use tokio::sync::Notify;
use tokio::sync::watch;

use crate::actor::ToActor;
Expand All @@ -24,6 +25,7 @@
pub envoy_key: String,
pub envoy_tx: mpsc::UnboundedSender<ToEnvoyMessage>,
pub actors: Arc<StdMutex<HashMap<String, HashMap<u32, SharedActorEntry>>>>,
pub actors_notify: Arc<Notify>,
pub live_tunnel_requests: Arc<StdMutex<HashMap<[u8; 8], String>>>,
pub pending_hibernation_restores:
Arc<StdMutex<HashMap<String, Vec<HibernatingWebSocketMetadata>>>>,
Expand Down
4 changes: 4 additions & 0 deletions engine/sdks/rust/envoy-client/src/envoy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ impl EnvoyContext {
},
);

self.shared.actors_notify.notify_waiters();

if let Some(messages) = self.buffered_actor_messages.remove(&buffered_actor_id) {
for message in messages {
match message {
Expand Down Expand Up @@ -216,6 +218,7 @@ impl EnvoyContext {
shared.remove(actor_id);
}
}
self.shared.actors_notify.notify_waiters();
}

pub fn get_actor(&self, actor_id: &str, generation: Option<u32>) -> Option<&ActorEntry> {
Expand Down Expand Up @@ -297,6 +300,7 @@ fn start_envoy_sync_inner(config: EnvoyConfig) -> EnvoyHandle {
envoy_key,
envoy_tx: envoy_tx.clone(),
actors: Arc::new(std::sync::Mutex::new(HashMap::new())),
actors_notify: Arc::new(tokio::sync::Notify::new()),
live_tunnel_requests: Arc::new(std::sync::Mutex::new(HashMap::new())),
pending_hibernation_restores: Arc::new(std::sync::Mutex::new(HashMap::new())),
ws_tx: Arc::new(tokio::sync::Mutex::new(None)),
Expand Down
1 change: 1 addition & 0 deletions engine/sdks/rust/envoy-client/src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ mod tests {
envoy_key: "test-envoy".to_string(),
envoy_tx,
actors: Arc::new(std::sync::Mutex::new(HashMap::new())),
actors_notify: Arc::new(tokio::sync::Notify::new()),
live_tunnel_requests: Arc::new(std::sync::Mutex::new(HashMap::new())),
pending_hibernation_restores: Arc::new(std::sync::Mutex::new(HashMap::new())),
ws_tx: Arc::new(tokio::sync::Mutex::new(
Expand Down
104 changes: 92 additions & 12 deletions engine/sdks/rust/envoy-client/src/handle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
pub(crate) started_rx: tokio::sync::watch::Receiver<()>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ServerlessActorStart {
pub actor_id: String,
pub generation: u32,
}

impl EnvoyHandle {
#[doc(hidden)]
pub fn from_shared(shared: Arc<SharedContext>) -> Self {
Expand Down Expand Up @@ -85,6 +91,23 @@
&self.shared.config.namespace
}

pub fn active_actor_count(&self) -> usize {
let guard = self
.shared
.actors
.lock()
.expect("shared actor registry poisoned");
guard
.values()
.map(|generations| {
generations
.values()
.filter(|actor| !actor.handle.is_closed())
.count()
})
.sum()
}

pub fn pool_name(&self) -> &str {
&self.shared.config.pool_name
}
Expand Down Expand Up @@ -138,6 +161,40 @@
rx.await.ok().flatten()
}

pub async fn wait_actor_registered_then_stopped(&self, actor_id: &str, generation: u32) {
let mut registered = false;
loop {
let notified = self.shared.actors_notify.notified();
if self.is_stopped() {
return;
}

let actor_is_registered = {
let guard = self
.shared
.actors
.lock()
.expect("shared actor registry poisoned");
guard
.get(actor_id)
.and_then(|generations| generations.get(&generation))
.is_some()
};

if registered && !actor_is_registered {
return;
}
if actor_is_registered {
registered = true;
}

tokio::select! {
_ = notified => {}
_ = self.wait_stopped() => return,
}
}
}

pub fn http_request_counter(
&self,
actor_id: &str,
Expand Down Expand Up @@ -484,6 +541,35 @@
/// Inject a serverless start payload into the envoy.
/// The payload is a u16 LE protocol version followed by a serialized ToEnvoy message.
pub async fn start_serverless_actor(&self, payload: &[u8]) -> anyhow::Result<()> {
let (message, _) = decode_serverless_actor_start_payload(payload)?;

// Wait for envoy to be started before injecting
self.started().await?;

tracing::debug!(
data = crate::stringify::stringify_to_envoy(&message),
"received serverless start"
);
self.shared
.envoy_tx
.send(ToEnvoyMessage::ConnMessage { message })
.map_err(|_| anyhow::anyhow!("envoy channel closed"))?;

Ok(())
}

pub fn decode_serverless_actor_start(
&self,
payload: &[u8],
) -> anyhow::Result<ServerlessActorStart> {
let (_, actor_start) = decode_serverless_actor_start_payload(payload)?;
Ok(actor_start)
}
}

fn decode_serverless_actor_start_payload(

Check warning on line 570 in engine/sdks/rust/envoy-client/src/handle.rs

View workflow job for this annotation

GitHub Actions / Rustfmt

Diff in /home/runner/work/rivet/rivet/engine/sdks/rust/envoy-client/src/handle.rs

Check warning on line 570 in engine/sdks/rust/envoy-client/src/handle.rs

View workflow job for this annotation

GitHub Actions / Rustfmt

Diff in /home/runner/work/rivet/rivet/engine/sdks/rust/envoy-client/src/handle.rs
payload: &[u8],
) -> anyhow::Result<(protocol::ToEnvoy, ServerlessActorStart)> {
use vbare::OwnedVersionedData;

if payload.len() < 2 {
Expand Down Expand Up @@ -524,21 +610,15 @@
anyhow::bail!("invalid serverless payload: expected CommandStartActor");
}

// Wait for envoy to be started before injecting
self.started().await?;

tracing::debug!(
data = crate::stringify::stringify_to_envoy(&message),
"received serverless start"
);
self.shared
.envoy_tx
.send(ToEnvoyMessage::ConnMessage { message })
.map_err(|_| anyhow::anyhow!("envoy channel closed"))?;
let actor_start = ServerlessActorStart {
actor_id: commands[0].checkpoint.actor_id.clone(),
generation: commands[0].checkpoint.generation,
};

Ok(())
Ok((message, actor_start))
}

impl EnvoyHandle {
async fn send_kv_request(
&self,
actor_id: String,
Expand Down
1 change: 1 addition & 0 deletions engine/sdks/rust/envoy-client/src/sqlite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ mod tests {
envoy_key: "test-envoy".to_string(),
envoy_tx,
actors: Arc::new(std::sync::Mutex::new(HashMap::new())),
actors_notify: Arc::new(tokio::sync::Notify::new()),
live_tunnel_requests: Arc::new(std::sync::Mutex::new(HashMap::new())),
pending_hibernation_restores: Arc::new(std::sync::Mutex::new(HashMap::new())),
ws_tx: Arc::new(tokio::sync::Mutex::new(
Expand Down
36 changes: 36 additions & 0 deletions examples/kitchen-sink/frontend/page-data.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions examples/kitchen-sink/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading