Repository navigation
chore: move to ras-stack 0.39.0 and drop the adoption policy - #51
Merged
Merged
Conversation
0.39.0 removes the adoption policy feature, so the adoption block in ras-stack.policy.json is now inert config that nothing reads. Delete it rather than leave dead weight that looks like it still enforces something, and roll the release-age exclusion forward to the version we actually install.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
basekit | e743383 | Commit Preview URL Branch Preview URL |
Aug 14 2026, 08:51 PM |
The release-changesets pin was still on v0.35.0, which predates the v0.38.1 fix where a release run superseded by a later merge stands down cleanly instead of failing the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ras-stack 0.39.0 removed the adoption policy feature.
ras policy checknow only covers the Changesets config, Dependabot config, and the pnpm cooldown, and it ignores anadoptionblock instead of rejecting it. Ours still declared a minimum ras-stack version, toolchain pins, and required config references that nothing reads any more — config that looks enforced but isn't.Separately, CI still called the reusable workflows at
@v0.35.0while the package moved to 0.39.0. Therelease-changesets.ymlpin is the one that bites: it predates the v0.38.1 fix where a release run superseded by a later merge stands down cleanly instead of failing the build. On main that shows up as a red build for a release that was simply overtaken, not broken.Changes
ras-stackto^0.39.0and refresh the lockfile.adoptionblock fromras-stack.policy.json.minimumReleaseAgeExcludeentry fromras-stack@0.35.0toras-stack@0.39.0, since 0.39.0 is newer than the one-week cooldown..github/workflows/ci.ymlfrom@v0.35.0to@v0.39.0:check-js.yml,check-browser.yml, andrelease-changesets.yml. Versions only — the job inputs and the rest of the YAML are untouched.Risk
Low. Nothing in this repo calls
ras policy ... adoption, and the removed block was already inert on 0.39.0. Rolling back is a revert; the exclusion only affects fresh resolution, not installs against the committed lockfile.The workflow pins are the part CI actually exercises.
check-jsandcheck-browserrun from this branch's ref, so this PR's own run is the proof they work at 0.39.0. Thereleasejob is gated on a push to main, so it won't have run before merge — that one lands on trust in the upstream tag plus the fact that the pin it replaces is four minor versions stale.Verification
just check(format:check, lint, policy:check, typecheck, test, build) passes locally — 231 tests, cleanras policy check, successful build.pnpm install --frozen-lockfilepasses the supply-chain policy check with only the 0.39.0 exclusion in place. After the pin bump I re-ranjust checkand confirmed norichardsolomou/ras-stack/...@vreference below v0.39.0 remains under.github/workflows/.Checklist