Repository navigation
fix: preserve unobserved causes in accuracy_in_time - #51
Merged
rich-iannone merged 1 commit intoOct 9, 2026
Merged
Conversation
rich-iannone
approved these changes
Oct 9, 2026
rich-iannone
left a comment
Owner
There was a problem hiding this comment.
Great improvement, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accuracy_in_time()counts only observed event causes when validating prediction arrays, although the cause axis must follow the response's declared states. With states("relapse", "death")and only death events (code 2), it rejects valid two-cause predictions. A compressed one-cause array is instead accepted and can return an incorrect accuracy.Use
Surv.stateswhen available to preserve cause codes across subsets, retain the existing single-event fallback, and clarify the docstring. Add five regression cases for missing first/middle/last causes, all-censored data, and rejection of compressed cause axes.Validation
The full suite ran with two workers and coverage from
python/. Existing skips include optional great-tables visualizations and dependency-specific forest paths. No estimator formulas or R-generated fixtures changed.Checklist
R-parity fixture changes are not applicable: this fixes cause-axis validation without changing estimator formulas.