chore: use the API timestamp format in fixtures and docstrings - #249
Merged
Conversation
The API returns timestamps in Postgres text format (2023-10-06 23:47:56.678+00), not ISO 8601. Test fixtures and docstrings claimed ISO 8601 for response fields. Convert response fixtures to the real format. Remove the ISO 8601 claims from response docstrings. Fix the webhook data.created_at fixtures to millisecond precision with Z, which matches real webhook output. Keep ISO 8601 where the API uses it: the scheduled_at request param, webhook event payloads, and revoked_at in the revoke response. No runtime changes.
klotty
approved these changes
Aug 6, 2026
klotty
left a comment
There was a problem hiding this comment.
No issues found across 45 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Updates test fixtures and docstrings to match the API's actual timestamp format (Postgres text). No runtime behavior changes; purely cosmetic/test alignment with no operational, security, or data tradeoffs.
Re-trigger cubic
drish
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The API returns timestamps in Postgres text format:
YYYY-MM-DD HH:MM:SS[.ffffff]+00(for example2023-10-06 23:47:56.678+00). Our test fixtures and docstrings showed ISO 8601 for response fields. This PR makes them match the real API output.data.created_atfixtures from…894719+00:00to…894Z. Real webhooks emit millisecond precision withZ.What stays ISO 8601 on purpose
scheduled_atas a request parameter. The API accepts ISO there.revoked_atin the revoke OAuth grant response. That endpoint returns ISO.Why
The SDK never parses these values, so there are no runtime changes. But wrong fixtures propagate: new endpoints copy the pattern, and users who read the tests get the wrong contract.
Verification
pytest: 558 passed.tox -e lint: OK.tox -e mypy: no issues in 176 files.Summary by cubic
Align fixtures and docstrings with the API’s timestamp format (Postgres text). No runtime behavior changes.
scheduled_atrequest param, webhook payloads, andrevoked_atin the revoke OAuth grant response.Written for commit 0eef200. Summary will update on new commits.