Repository navigation
Exclude jackson-bom from Renovate updates - #10
Merged
Merged
Conversation
jackson must match the version bundled with Trino: jackson annotation classes are parent-first in Trino's plugin classloader, so a mismatched jackson-databind fails with NoClassDefFoundError on deploy (see the note in gradle/libs.versions.toml). Renovate grouped a jackson-bom 2.22.2 bump into its java minor updates PR, which CI cannot catch because the issue only appears when the plugin is loaded by a real Trino server. Disable jackson-bom updates; bump it manually together with trino. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hyh23au5JR5bBfXxg3MKeh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renovate's grouped PR #7 includes a
jackson-bom2.20.1 → 2.22.2 bump. That violates the constraint documented ingradle/libs.versions.toml: jackson must match the version bundled with Trino 476 (airbase 336 → jackson 2.20.1), becausecom.fasterxml.jackson.annotation.*is parent-first in Trino's plugin classloader and a newer jackson-databind fails withNoClassDefFoundErroron deploy. CI cannot catch this — it only manifests when the plugin is loaded by a real Trino server, not in the in-process test harness.This adds a
packageRulesentry disablingcom.fasterxml.jackson:jackson-bomupdates, with a description explaining that jackson moves in lockstep with thetrinoversion.After merging
Renovate will regenerate PR #7 without the jackson bump, leaving the ADBC 0.24.0 / AssertJ / Derby updates, which can then be merged as-is.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Hyh23au5JR5bBfXxg3MKeh