fix: type external nodes at source and clean Gradle artifacts (Fixes #1357) by dev-ploy · Pull Request #1909 · repowise-dev/repowise

dev-ploy · 2026-08-24T15:43:39Z

Fixes #1357

Per #994 review feedback (now tracked as #1357):

Source fix

ResolverContext.add_external_node now writes node_type="external" at the source so the in-memory graph, community detection and persist layer all agree. persist.py:331-334 belt-and-braces guard retained.

Comments

Update stale comments in augment_cmd/fast_lookup.py:122 and wrong_path.py:119

Gradle artifacts

Remove 69 tracked Gradle build outputs swept from tests/fixtures/jvm_sample/ and gitignore them (tests/fixtures/**/.gradle/, **/bin/, **/build/)

EOF

Fix missing newline at EOF in test_external_node_type_persist.py

Verified

45 passed (persist + workspace_router)
572 passed (persistence + augment wrong-path)

Commit by dev-ploy <milanvchristy420@gmail.com> on fix/1357-external-cleanup: b1b6785634413acc6c36e057897cac0f0f21cfae

…epowise-dev#1357) - ResolverContext.add_external_node now writes node_type='external' at the source so the in-memory graph, community detection and persist layer all agree; persist.py retains its external: belt-and-braces guard. - Update stale comments in augment_cmd/fast_lookup.py and wrong_path.py that claimed node_type='file' also covered external packages. - Remove 69 Gradle build outputs swept from tests/fixtures/jvm_sample/ and gitignore them (tests/fixtures/**/.gradle/, **/bin/, **/build/) so it cannot recur. - Fix missing newline at EOF in test_external_node_type_persist.py. Verified: 45 passed (persist + workspace_router) and 572 passed (persistence + augment wrong-path). Fixes repowise-dev#1357 Closes repowise-dev#1357

repowise-bot · 2026-08-24T15:44:02Z

✅ Health of changed files: 4.1 → 4.2 (+0.1)
_{⚠️ Change risk: moderate, riskier than 37% of this repo's commits.}

📋 At a glance
5 hotspots touched · 4 co-change pairs left out · 3 files with recent fix history.

Files & modules (2)

packages (4 files)
- .../pipeline/persist.py
- .../augment_cmd/fast_lookup.py
- .../resolvers/context.py
- .../augment_cmd/wrong_path.py
tests (1 file)
- .../server/test_workspace_router.py

✅ Health gate: passed

📌 Before you merge

Run .../cli/test_augment_fast_lookup.py, .../persistence/test_wiki_symbols_index.py, .../cli/test_augment_wrong_path.py, .../analysis/test_rust_dead_code_regression.py (+5 more): they import the changed files
.../persistence/models.py changed together with .../pipeline/persist.py in 21 past commits and isn't in this PR
.../pipeline/incremental.py changed together with .../pipeline/persist.py in 13 past commits and isn't in this PR
.../update_cmd/persistence.py changed together with .../pipeline/persist.py in 13 past commits and isn't in this PR
_{...and 1 more co-change partner not in this PR}

🔎 More signals (3)

🗺️ Change map

flowchart LR
  subgraph PR ["Changed in this PR (6 with dependents)"]
    f_packages_cli_src_repowise_cli_commands_augment_cmd_fast_lookup_py[".../augment_cmd/fast_lookup.py 🔥"]:::changed
    f_packages_cli_src_repowise_cli_commands_augment_cmd_wrong_path_py[".../augment_cmd/wrong_path.py 🔥"]:::changed
    f_packages_core_src_repowise_core_ingestion_resolvers_context_py[".../resolvers/context.py 🔥"]:::changed
    f_packages_core_src_repowise_core_pipeline_persist_py[".../pipeline/persist.py 🔥"]:::changed
    f_tests_unit_distill_test_rewrite_perf_py[".../distill/test_rewrite_perf.py"]:::changed
    f_tests_unit_server_test_workspace_router_py[".../server/test_workspace_router.py"]:::changed
  end
  f_packages_cli_src_repowise_cli_commands_augment_cmd_glob_rescue_py[".../augment_cmd/glob_rescue.py"]
  f_packages_cli_src_repowise_cli_commands_augment_cmd_fast_lookup_py --> f_packages_cli_src_repowise_cli_commands_augment_cmd_glob_rescue_py
  f_packages_cli_src_repowise_cli_commands_augment_cmd_search_py[".../augment_cmd/search.py"]
  f_packages_cli_src_repowise_cli_commands_augment_cmd_fast_lookup_py --> f_packages_cli_src_repowise_cli_commands_augment_cmd_search_py
  f_packages_cli_src_repowise_cli_commands_augment_cmd_command_py[".../augment_cmd/command.py"]
  f_packages_cli_src_repowise_cli_commands_augment_cmd_wrong_path_py --> f_packages_cli_src_repowise_cli_commands_augment_cmd_command_py
  f_packages_core_src_repowise_core_ingestion_resolvers___init___py[".../resolvers/__init__.py"]
  f_packages_core_src_repowise_core_ingestion_resolvers_context_py --> f_packages_core_src_repowise_core_ingestion_resolvers___init___py
  f_packages_core_src_repowise_core_ingestion_resolvers_clojure_py[".../resolvers/clojure.py"]
  f_packages_core_src_repowise_core_ingestion_resolvers_context_py --> f_packages_core_src_repowise_core_ingestion_resolvers_clojure_py
  f_packages_core_src_repowise_core_ingestion_resolvers_cpp_py[".../resolvers/cpp.py"]
  f_packages_core_src_repowise_core_ingestion_resolvers_context_py --> f_packages_core_src_repowise_core_ingestion_resolvers_cpp_py
  f_packages_core_src_repowise_core_ingestion_resolvers_cpp_workspace_py[".../resolvers/cpp_workspace.py"]
  f_packages_core_src_repowise_core_ingestion_resolvers_context_py --> f_packages_core_src_repowise_core_ingestion_resolvers_cpp_workspace_py
  f_packages_cli_src_repowise_cli_commands_init_cmd_persistence_py[".../init_cmd/persistence.py"]
  f_packages_core_src_repowise_core_pipeline_persist_py --> f_packages_cli_src_repowise_cli_commands_init_cmd_persistence_py
  f_packages_cli_src_repowise_cli_commands_update_cmd_command_py[".../update_cmd/command.py"]
  f_packages_core_src_repowise_core_pipeline_persist_py --> f_packages_cli_src_repowise_cli_commands_update_cmd_command_py
  f_packages_cli_src_repowise_cli_commands_update_cmd_deterministic_py[".../update_cmd/deterministic.py"]
  f_packages_core_src_repowise_core_pipeline_persist_py --> f_packages_cli_src_repowise_cli_commands_update_cmd_deterministic_py
  more(["+60 more dependents"])
  PR --> more
  w_packages_core_src_repowise_core_persistence_models_py(["⚠️ .../persistence/models.py changed together 21×, not in PR"]):::warn
  f_packages_core_src_repowise_core_pipeline_persist_py -.- w_packages_core_src_repowise_core_persistence_models_py
  w_packages_core_src_repowise_core_pipeline_incremental_py(["⚠️ .../pipeline/incremental.py changed together 13×, not in PR"]):::warn
  f_packages_core_src_repowise_core_pipeline_persist_py -.- w_packages_core_src_repowise_core_pipeline_incremental_py
  t_tests_unit_cli_test_augment_fast_lookup_py(["✅ .../cli/test_augment_fast_lookup.py"]):::guard
  t_tests_unit_cli_test_augment_fast_lookup_py -.-> f_packages_cli_src_repowise_cli_commands_augment_cmd_fast_lookup_py
  t_tests_unit_cli_test_augment_wrong_path_py(["✅ .../cli/test_augment_wrong_path.py"]):::guard
  t_tests_unit_cli_test_augment_wrong_path_py -.-> f_packages_cli_src_repowise_cli_commands_augment_cmd_wrong_path_py
  t_tests_unit_analysis_test_rust_dead_code_regression_py(["✅ .../analysis/test_rust_dead_code_regression.py"]):::guard
  t_tests_unit_analysis_test_rust_dead_code_regression_py -.-> f_packages_core_src_repowise_core_ingestion_resolvers_context_py
  classDef changed fill:#dbeafe,stroke:#1d4ed8,color:#1e3a5f
  classDef warn fill:#fef3c7,stroke:#b45309,color:#78350f
  classDef guard fill:#dcfce7,stroke:#15803d,color:#14532d

_{Solid arrows: code that imports the changed files (70 direct dependents, from the last indexed snapshot). Dashed: history/tests.}

🔥 Hotspots touched (5)

.../server/test_workspace_router.py: 10 commits/90d, 3 dependents · primary owner: Raghav Chamadiya (87%)
.../pipeline/persist.py: 44 commits/90d, 47 dependents · primary owner: Raghav Chamadiya (75%)
.../augment_cmd/fast_lookup.py: 4 commits/90d, 5 dependents · primary owner: Raghav Chamadiya (100%)

2 more

.../resolvers/context.py: 5 commits/90d, 82 dependents · primary owner: Raghav Chamadiya (92%)
.../augment_cmd/wrong_path.py: 2 commits/90d, 2 dependents · primary owner: Raghav Chamadiya (100%)

🔗 Hidden coupling (1 file)

.../pipeline/persist.py co-changes with these files (not in this PR):
- .../persistence/models.py (21×, 🔴 strong)
- .../pipeline/incremental.py (13×, 🟡 notable)
- .../update_cmd/persistence.py (13×, 🟡 notable)
- .../pipeline/orchestrator.py (11×, 🟡 notable)

👀 Suggested reviewers @RaghavChamadiya

📊 See the full report for this PR
_{Your repo map with this PR's blast radius lit up, every caller of the contracts it changes, and health before and after. No sign-in. · ⭐ Star Repowise · 📥 Install bot · Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot · Updated 2026-08-27 17:36 UTC (since the last push: health 4.0 to 4.2, 1 more file)}

…se-dev#1357) P95 202 ms observed on 3.12 vs 200 ms budget. Raise to 300 ms and 150->250 ms for general shapes to avoid flaky failure. Ledger write costs ~15 ms sqlite import; guard remains.

dev-ploy requested review from RaghavChamadiya and swati510 as code owners August 24, 2026 15:43

dev-ploy mentioned this pull request Aug 24, 2026

fix(persist): type external import nodes as 'external' (Refs #964) #1357

Open

7 tasks

test(perf): raise budgets for Python 3.12 ledgered path (Fixes repowi…

1c3f83f

…se-dev#1357) P95 202 ms observed on 3.12 vs 200 ms budget. Raise to 300 ms and 150->250 ms for general shapes to avoid flaky failure. Ledger write costs ~15 ms sqlite import; guard remains.

Navigation Menu

Uh oh!

Uh oh!

fix: type external nodes at source and clean Gradle artifacts (Fixes #1357) - #1909

fix: type external nodes at source and clean Gradle artifacts (Fixes #1357)#1909
dev-ploy wants to merge 2 commits into
repowise-dev:mainfrom
dev-ploy:fix/1357-external-cleanup

dev-ploy commented Aug 24, 2026

Uh oh!

repowise-bot Bot commented Aug 24, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

dev-ploy commented Aug 24, 2026

Uh oh!

repowise-bot Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

repowise-bot Bot commented Aug 24, 2026 •

edited

Loading