Skip to content

ethernet: add checksum offloading #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaurikaSohnvi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ethernet: add checksum offloading #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8e9e4
net: SynopsysDWCEthernetQoS: Add RX checksum offload validation
GaurikaSohnvi Mar 24, 2026
d833407
net: SynopsysDWCEthernetQoS: Fix TX checksum insertion gating
GaurikaSohnvi Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions ...ls/Network/SynopsysDWCEthernetQualityOfService/SynopsysDWCEthernetQualityOfService_DMA.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,9 +531,18 @@ private void StartRx()
writeBackStructure.OuterVlanTag = 0x0;
writeBackStructure.InnerVlanTag = 0x0;
writeBackStructure.OamSubtypeCodeOrMACControlPacketOpcode = (uint)frame.UnderlyingPacket.Type;
writeBackStructure.IpHeaderError = false;
writeBackStructure.Ipv4HeaderPresent = frame.UnderlyingPacket.Type == EthernetPacketType.IpV4;
writeBackStructure.Ipv6HeaderPresent = frame.UnderlyingPacket.Type == EthernetPacketType.IpV6;

// Validate IP header checksum if checksum offload is enabled
writeBackStructure.IpHeaderError = false;
writeBackStructure.IpChecksumBypassed = !parent.checksumOffloadEnable.Value;
if(parent.checksumOffloadEnable.Value && writeBackStructure.Ipv4HeaderPresent)
{
var ipv4Packet = (IPv4Packet)frame.UnderlyingPacket.PayloadPacket;
writeBackStructure.IpHeaderError = !ipv4Packet.ValidChecksum;
}

if(writeBackStructure.Ipv4HeaderPresent || writeBackStructure.Ipv6HeaderPresent)
{
switch(((IpPacket)frame.UnderlyingPacket.PayloadPacket).NextHeader)
Expand Down Expand Up @@ -622,6 +631,27 @@ private void StartRx()
writeBackStructure.ReceiveWatchdogTimeout = false;
writeBackStructure.GiantPacket = false;
writeBackStructure.CrcError = parent.crcCheckDisable.Value ? false : !EthernetFrame.CheckCRC(bytes);

// Validate payload checksum if checksum offload is enabled
writeBackStructure.IpPayloadError = false;
if(parent.checksumOffloadEnable.Value && (writeBackStructure.Ipv4HeaderPresent || writeBackStructure.Ipv6HeaderPresent))
{
var ipPacket = (IpPacket)frame.UnderlyingPacket.PayloadPacket;
if(ipPacket.PayloadPacket is TcpPacket tcpPacket)
{
writeBackStructure.IpPayloadError = !tcpPacket.ValidChecksum;
}
else if(ipPacket.PayloadPacket is UdpPacket udpPacket)
{
// UDP checksum is optional in IPv4, mandatory in IPv6
if(udpPacket.Checksum != 0 || writeBackStructure.Ipv6HeaderPresent)
{
writeBackStructure.IpPayloadError = !udpPacket.ValidChecksum;
}
}
// Note: ICMP checksum validation could be added here if PacketDotNet supports it
}

writeBackStructure.ErrorSummary = new bool[]
{
writeBackStructure.DribbleBitError,
Expand Down Expand Up @@ -777,7 +807,7 @@ private void StartTx()
buffer,
(uint)maximumSegmentSize.Value,
latestTxContext,
parent.checksumOffloadEnable.Value,
true, // TSO always requires checksum offload
parent.SendFrame,
sourceAddress
);
Expand All @@ -789,7 +819,7 @@ private void StartTx()
frameAssembler = new FrameAssembler(
parent,
structure.CrcPadControl,
parent.checksumOffloadEnable.Value ? structure.ChecksumControl : ChecksumOperation.None,
structure.ChecksumControl, // TX checksum insertion is controlled by descriptor CIC field, not MACCR.IPC (RX-only)
parent.SendFrame
);
}
Expand Down Expand Up @@ -847,6 +877,7 @@ private void StartTx()
writeBackStructure.LateCollision = false;
writeBackStructure.NoCarrier = false;
writeBackStructure.LossOfCarrier = false;
// Payload checksum errors are reported on RX path, not TX
writeBackStructure.PayloadChecksumError = false;
writeBackStructure.PacketFlushed = false;
writeBackStructure.JabberTimeout = false;
Expand Down