Skip to content

Fix Metal command buffer ownership in command lists #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdlewis wants to merge 3 commits into from
Closed

Fix Metal command buffer ownership in command lists #96

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd89b9e
Fix Metal command buffer ownership in command lists
cdlewis May 22, 2026
371250a
Retain Metal blit encoder stored on command list
cdlewis May 22, 2026
555ed19
TextureDescriptor was not owned so it does not need to be released
cdlewis May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plume_metal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2238,7 +2238,9 @@ namespace plume {
}

MetalCommandList::~MetalCommandList() {
mtl->release();
if (mtl != nullptr) {
Comment thread
DarioSamo marked this conversation as resolved.
mtl->release();
}

for (auto& fenceSet : fences) {
for (auto* fence : fenceSet) {
Expand All @@ -2253,6 +2255,7 @@ namespace plume {
assert(mtl == nullptr);
startedEncoding = false;
mtl = queue->mtl->commandBufferWithUnretainedReferences();
mtl->retain();

@squidbus squidbus May 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a retain here is right but also needs an autorelease pool around this function.

mtl->setLabel(MTLSTR("RT64 Command List"));

// Reset fence waits and updates for new command list.
Expand Down