Skip to content

feat: add optional maxFeeMsat to pay_invoice (NIP-47 max_fee) #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frnandu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add optional maxFeeMsat to pay_invoice (NIP-47 max_fee) #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ndk/lib/domain_layer/usecases/nwc/consts/error_code.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ enum ErrorCode {
),
unauthorized('UNAUTHORIZED', 'This public key has no wallet connected.'),
internal('INTERNAL', 'An internal error.'),
feeLimitExceeded(
'FEE_LIMIT_EXCEEDED',
'No route fit the max_fee budget and no payment was attempted.',
),
other('OTHER', 'Other error.');

final String value;
Expand Down
3 changes: 2 additions & 1 deletion packages/ndk/lib/domain_layer/usecases/nwc/nwc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,12 @@ class Nwc {
Future<PayInvoiceResponse> payInvoice(
NwcConnection connection, {
required String invoice,
int? maxFeeMsat,
Duration? timeout,
}) async {
return _executeRequest<PayInvoiceResponse>(
connection,
PayInvoiceRequest(invoice: invoice),
PayInvoiceRequest(invoice: invoice, maxFeeMsat: maxFeeMsat),
timeout: timeout,
);
}
Expand Down
11 changes: 8 additions & 3 deletions packages/ndk/lib/domain_layer/usecases/nwc/requests/pay_invoice.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,20 @@ import 'nwc_request.dart';
// Subclass for requests to pay a bolt11 invoice
class PayInvoiceRequest extends NwcRequest {
final String invoice;
final int? maxFeeSat;

const PayInvoiceRequest({required this.invoice})
: super(method: NwcMethod.PAY_INVOICE);
const PayInvoiceRequest({required this.invoice, int? maxFeeMsat})
: maxFeeSat = maxFeeMsat == null ? null : maxFeeMsat ~/ 1000,
super(method: NwcMethod.PAY_INVOICE);

@override
Map<String, dynamic> toMap() {
return {
...super.toMap(),
'params': {'invoice': invoice},
'params': {
'invoice': invoice,
if (maxFeeSat != null) 'max_fee': maxFeeSat! * 1000,
},
};
}
}
Loading