colocate: ignore empty module names#166
Open
sjbarag wants to merge 1 commit into
Open
Conversation
When extracting module names with utils::getModuleName, any explicit or implicit import of an 'index' file in a module's directory or one of its parents resolves to an empty string. Since all JS strings begin with an empty string, this is considered a matching module name for a used fragment spread. Subsequent imports are ignored because a module name matches. However, the falsiness of the empty string causes an error to still be reported. In pathological cases, an empty module name can be imported _before_ the import that correctly matches a used fragment spread. This resulted in a false-positive "must be colocated" error, despite the fact that the required import is in fact present. Ignore empty module names when looking for imports that satisfy a fragment spread's colocation requirement.
Author
|
Not sure what the backwards-compatibility policy is now that v2.0.0 has been released, but this seems like it'd be a pretty simple backport onto the 1.x branch 🙂. I haven't updated to Relay v20 or |
Author
|
(bump) do any of the maintainers have time to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting module names with utils::getModuleName, any explicit or implicit import of an 'index' file in a module's directory or one of its parents resolves to an empty string. Since all JS strings begin with an empty string, this is considered a matching module name for a used fragment spread. Subsequent imports are ignored because a module name matches. However, the falsiness of the empty string causes an error to still be reported.
In pathological cases, an empty module name can be imported before the import that correctly matches a used fragment spread. This resulted in a false-positive "must be colocated" error, despite the fact that the required import is in fact present.
Ignore empty module names when looking for imports that satisfy a fragment spread's colocation requirement.