Skip to content

Add the hubverse model output interface #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickreich merged 2 commits into from
Sep 2, 2026
Merged

Add the hubverse model output interface #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
677ef6e
Add the hubverse model output interface
nickreich Sep 2, 2026
b4c4e31
Pin numerical equivalence with the original alloscore
nickreich Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Imports:
cli,
distfromq,
dplyr,
hubUtils,
purrr,
rlang,
stats,
Expand All @@ -35,7 +36,11 @@ Imports:
tidyselect
Suggests:
covr,
hubExamples,
jsonlite,
testthat (>= 3.0.0)
Remotes:
hubverse-org/hubExamples
Depends:
R (>= 4.1.0)
LazyData: true
Expand Down
3 changes: 3 additions & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ S3method(alloscore,slim)
S3method(weights,allocated)
export(add_pdqr_funs)
export(allocate)
export(allocate_model_out)
export(alloscore)
export(alloscore_model_out)
export(as_alloscore_df)
export(dexp_gpl_df)
export(dexp_gpl_loss)
export(dexp_over_loss)
Expand Down
9 changes: 9 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,12 @@

* `weights.allocated()` and `alloscore.slim()` now match the signatures of their
generics.

* Added `as_alloscore_df()`, `allocate_model_out()` and `alloscore_model_out()`,
which take a hubverse `model_out_tbl` and `oracle_output` directly. Predictive
quantiles are turned into cdfs and quantile functions with `distfromq`, so the
conversion that callers used to hand-roll is no longer needed. Only the
`quantile` output type is supported.

* Results agree with the original package to within root-finding tolerance; see
`tests/testthat/test-legacy-equivalence.R`.
Loading
Loading