Fix dependency update token mismatch#5997
Closed
alceops wants to merge 1 commit intoregro:mainfrom
Closed
Conversation
154f28a to
a8557d4
Compare
Author
|
Closing this duplicate in favor of #5999 to keep maintainer review focused on one PR. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5996.
This makes
_apply_env_dep_comparison()robust when the dependency comparison uses a package token such ascuda-version, but the recipe contains a constrained dependency line such ascuda-version >=12,<13.Changes:
ValueError;Local verification:
python -m py_compile conda_forge_tick/update_deps.py tests/test_update_deps.pygit diff --checkI could not run the targeted pytest locally because this runner is missing the test dependency
networkx, so I left the PR narrow for CI/review iteration.