Skip to content

Fix dependency update token mismatch#5997

Closed
alceops wants to merge 1 commit intoregro:mainfrom
alceops:alce/fix-env-dep-token-mismatch
Closed

Fix dependency update token mismatch#5997
alceops wants to merge 1 commit intoregro:mainfrom
alceops:alce/fix-env-dep-token-mismatch

Conversation

@alceops
Copy link
Copy Markdown

@alceops alceops commented Apr 30, 2026

Fixes #5996.

This makes _apply_env_dep_comparison() robust when the dependency comparison uses a package token such as cuda-version, but the recipe contains a constrained dependency line such as cuda-version >=12,<13.

Changes:

  • prefer exact dependency text matches when applying comparison patches;
  • fall back to matching the package token before removing/updating;
  • skip missing remove/update targets instead of raising a bare ValueError;
  • add focused regression coverage for token-match update and missing-remove skip.

Local verification:

  • python -m py_compile conda_forge_tick/update_deps.py tests/test_update_deps.py
  • git diff --check

I could not run the targeted pytest locally because this runner is missing the test dependency networkx, so I left the PR narrow for CI/review iteration.

@alceops alceops force-pushed the alce/fix-env-dep-token-mismatch branch from 154f28a to a8557d4 Compare April 30, 2026 22:35
@alceops
Copy link
Copy Markdown
Author

alceops commented May 1, 2026

Closing this duplicate in favor of #5999 to keep maintainer review focused on one PR. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_apply_env_dep_comparison crashes with ValueError when dep in cf_minus_df doesn't match recipe text exactly

1 participant