[bugfix] Treat . properly in external references keys#3658
Merged
vkarak merged 1 commit intoreframe-hpc:developfrom Apr 29, 2026
Merged
[bugfix] Treat . properly in external references keys#3658vkarak merged 1 commit intoreframe-hpc:developfrom
. properly in external references keys#3658vkarak merged 1 commit intoreframe-hpc:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3658 +/- ##
===========================================
- Coverage 91.87% 91.87% -0.01%
===========================================
Files 62 62
Lines 13755 13756 +1
===========================================
Hits 12638 12638
- Misses 1117 1118 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Using `.` internal for denoting the key levels was problematic for keys that were regexes. We no more use `.` as an internal separator of key levels; we represent them internally as a list. We use `.` to concatenate them for error reporting only. Signed-off-by: Vasileios Karakasis <vkarakasis@nvidia.com>
vkarak
force-pushed
the
bugfix/extrefs-keys-with-dots
branch
from
fc883ef to
71c40b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
.internal for denoting the key levels was problematic for keys that were regexes.We no more use
.as an internal separator of key levels; we represent them internally as a list.We use
.to concatenate them for error reporting only.This is a follow up of #3630.