Qualify shared beam parameters with probe name for probeset and polarized - #388
Merged
Conversation
acaruana2009
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically tags the parameter name with the probe name for shared beam parameters.
For non-shared polarized probes, the beam parameters are not being tagged with cross section. This PR does not address this.
We now share the beam parameters from the first probe rather than creating new parameters. This will only apply to parameters not explicitly listed in the
shared_beamcall.Any initial guesses such as
background=1e-6ortheta_offset=0.01that were given when the first probe was loaded will propagate to all the other probes. For the polref loader (#382), that meanstheta_offsetetc. specified in theload_probe_polrefcall will be respected in the shared beam, without needing a separateprobe.shared_beam(theta_offset=...)after loading.The parameters will still be qualified with the name from the first probe. That's a little ugly if the probes have unique names (cross section or sequence number for example). If that's a problem we can copy it and give it a new name.
Things to consider:
parameter.equals(shared)rather thanparameter=sharedto constrain them. That way we can unlink them to stop sharing. If they are shared by assignment, we would need to make a copy of the parameter to stop sharing. The two parameters will share the same name, which will be confusing.