Support Ruby 3.x through 4.0 - #104
Merged
Merged
Conversation
Update mobility to version 1.2.9 supporting Ruby 3. Update tests to use Ruby 3 syntax
parndt
reviewed
May 11, 2023
Member
|
Got CI running. Strangely, only Ruby 3.1 works and not 3.0 or 3.2 🤔 |
|
Shouldn't line 29 of /lib/refinery/i18n-filter.rb be changed to result.url !~ %r{^/(#{Refinery::Core.backend_route}|wymiframe)} |
result is a url, not a page
Contributor
Author
|
Closed and reopened to trigger new set of checks |
update version to 5.0.2 override the routing-filter/find_routes as recommended in svenfuchs/routing-filter#87 move complex conditions to methods in i18n-filter clarify logic in find_or_set_local remove flag icons as they are no longer used
Refactor routing filter overrides for Rails compatibility.
Refactor routing filter for Rails compatibility.
Updated routing filter compatibility for Rails versions 7.1 and 8.0.
Refactor routing filter overrides for Rails compatibility.
parndt
reviewed
Jan 2, 2026
parndt
approved these changes
Jan 2, 2026
Member
|
Thanks so much @anitagraham |
parndt
added a commit
to refinery/refinerycms
that referenced
this pull request
Jan 16, 2026
This PR and its matching PR refinery/refinerycms-i18n#104 allow `refinerycms` to run with Ruby 3 / Ruby 4. It has been tested with Ruby 3.2 through 4.0, and with Rails 6.1 through 8.1. We've removed `coffee-rails` as a dependency and converted those to JS. --------- Co-authored-by: Philip Arndt <git@p.arndt.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates refinerycms-i18n to Ruby 3, to match refinery/refinerycms#3518.
Using Mobility 1.3.x
Apart from that most changes are extremely minor.