Migration of kube-rbac-proxy in gitops-operator#1119
Merged
openshift-merge-bot[bot] merged 19 commits intoredhat-developer:masterfrom Apr 22, 2026
Merged
Migration of kube-rbac-proxy in gitops-operator#1119openshift-merge-bot[bot] merged 19 commits intoredhat-developer:masterfrom
openshift-merge-bot[bot] merged 19 commits intoredhat-developer:masterfrom
Conversation
akhilnittala
force-pushed
the
usr/akhil/GITOPS-9256
branch
from
5a69e7b to
9938bfd
Compare
Member
|
Cluster flake |
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
akhilnittala
force-pushed
the
usr/akhil/GITOPS-9256
branch
from
c205a21 to
de42adc
Compare
Signed-off-by: akhil nittala <nakhil@redhat.com>
svghadi
reviewed
Apr 15, 2026
svghadi
reviewed
Apr 15, 2026
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
Member
Author
|
/retest-failed |
Member
Author
|
/retest-required |
Signed-off-by: akhil nittala <nakhil@redhat.com>
svghadi
reviewed
Apr 21, 2026
svghadi
reviewed
Apr 21, 2026
Comment on lines
-349
to
-353
| Expect(container.Env).To(ContainElement(And( | ||
| HaveField("Name", "REDIS_PASSWORD"), | ||
| HaveField("ValueFrom.SecretKeyRef", Not(BeNil())), | ||
| )), "REDIS_PASSWORD should be set with valueFrom.secretKeyRef") | ||
|
|
Collaborator
There was a problem hiding this comment.
Thanks for bringing this to my attention. This will be changed by https://github.com/redhat-developer/gitops-operator/pull/1112/changes#diff-2ac629a59849dbdad312d82f8074b263b8e35b9913aa46dbd704b30ed5214e1cR393.
If that PR is merged first, it will be undesirable to remove the block, of course.
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest-required |
openshift-merge-bot
Bot
merged commit 830b1dd
into
redhat-developer:master
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Since kube-rbac-proxy has been officially deprecated and removed from the GCR repository, we are eliminating this image dependency by transitioning to the controller-runtime’s built-in functionality.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
https://redhat.atlassian.net/browse/GITOPS-9256
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Install gitops operator with this changes and verify gitops operator now has only one container created, but metrics should be there as it is without impacting gitops operator metrics functionality.