[Anish701]

What

If an MCP tool call failed, the tool would be displayed in red as an error, but if user refreshed the page or went back to that conversation in history, the tool would go back to being showed as success. This is because the "status: error" field was not getting saved in chat history. This PR fixes the bug by saving status: message.status in chat history for MCP tools

Fixes #344

How

• src/frontend/services/agent-rest.ts: save status: message.status in records of function combineToolCallandResult
• src/frontend/services/agent-rest.test.ts: test and validate the behavior

Testing

• Unit tests added/updated
• Ran locally (npm run dev)
• Manual verification (describe below if applicable)

Rollback

revert the commit

Checklist

• PR title follows Conventional Commits (feat:, fix:, ci:, etc.)
• No secrets, credentials, or PII in the diff
• No breaking changes (or documented above with a migration path)
• Lint and tests pass (npm run lint && npm run test)

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

When getThreadState merges a tool result into its matching AI tool call, it now copies the result’s status. The history test checks error, success, and undefined statuses.

Suggested reviewers: atrikghosh

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · up to 4bc2d

Historic tool errors retain their status on the inspected path. No merge-blocking issue remains.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the fix for MCP tool error display in historic chats.
Linked Issues check		Issue #344 requests preserving MCP tool error display in historic chats. combineToolCallandResult in src/frontend/services/agent-rest.ts now copies the tool result status onto its matching tool …
Out of Scope Changes check		The reported implementation and test changes both support issue #344. The available evidence shows no unrelated changes.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Description check		The description explains that the change preserves MCP tool error status in chat history and adds tests for the behavior.

Full details: Linked Issues check

Explanation

Issue #344 requests preserving MCP tool error display in historic chats. combineToolCallandResult in src/frontend/services/agent-rest.ts now copies the tool result status onto its matching tool call. The history test checks error, success, and undefined statuses.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Post-Merge Actions

• Update changelog

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /.coderabbit/rules/no-dangerously-set-innerhtml.yml

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Recent review info

Run configuration

• Source mode: Auto
• Repository: redhat-data-and-ai/template-ui
• Branch: main
• File: .coderabbit.yaml
• Commit: 35a380f
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Enterprise
• Run ID: 5ae12429-5713-4c78-a568-2d2bf3fc6074

Commits

Reviewing files that changed from the base of the PR and between 35a380f and 4bc2d1d.

Files selected for processing: 2

• src/frontend/services/agent-rest.test.ts
• src/frontend/services/agent-rest.ts

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• redhat-data-and-ai/template-agent (manual)
• redhat-data-and-ai/template-mcp (manual)

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

[abhiskum]

Looks good to me.

[nirmchan]

LGTM