Fix shutdown ordering for OOP IPlugin Release#2171
Open
nxtum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix shutdown of plugins where IPlugin itself is hosted by ThunderPlugin OOP
The failing release was the host releasing the plugin interface itself
ReleaseInterfaces() could terminate _connection before releasing currentIF
ThunderPlugin could call WorkerPool:Stop() from the ServiceAdministrator callback when the final IPlugin object was destroyed
That allowed the ThunderPlugin process to close while the host was still waiting for the remote currentIF->Release() to complete...