Add configurable sinks to postmortem WorkerPool and callstack dumps#2169
Merged
Conversation
…ck dumps Introduces PostMortemDataSink enum (FILE/LOG/ALL/DISABLED) to independently control where WorkerPool JSON snapshots and callstack dumps are written on crash. Defaults: wpSink=FILE, csSink=DISABLED. - Config.h: add PostMortemDataSink enum, parse helpers, new accessors - CMakeLists.txt: add POSTMORTEM_WORKERPOOL_SINK / POSTMORTEM_CALLSTACK_SINK CMake options with compile-time defaults - GenericConfig.cmake / WPEFramework.conf.in / params.config: expose new config keys (postmortemworkerpoolsink, postmortemcallstacksink, postmortemcallstackdumppath) - PluginServer.h: gate DumpCallStack, file write, and syslog output behind runtime sink checks; add DumpReadableMetadata() for human-readable ThunderInternals.txt output
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable “sinks” for postmortem outputs in the Thunder daemon so operators can independently control whether crash-time WorkerPool snapshots and callstack dumps go to files, logs, both, or are disabled.
Changes:
- Introduces
PostMortemDataSinkplus config parsing/accessors forpostmortemworkerpoolsink,postmortemcallstacksink, andpostmortemcallstackdumppath. - Adds CMake options to set compile-time defaults for the WorkerPool and callstack sinks.
- Updates daemon config templates/parameter lists and gates postmortem dump emission based on the selected sinks.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Thunder/Thunder.conf.in | Exposes new postmortem sink/path keys in the generated daemon configuration. |
| Source/Thunder/PluginServer.h | Applies sink-based gating for WorkerPool JSON emission and readable dump output; adds log/file routing logic. |
| Source/Thunder/params.config | Registers the new config keys in the parameter list. |
| Source/Thunder/GenericConfig.cmake | Adds mapping for the new sink/path configuration variables (including callstack dump path). |
| Source/Thunder/Config.h | Adds PostMortemDataSink, parsing helper, JSON fields, and accessors for new config values/defaults. |
| Source/Thunder/CMakeLists.txt | Adds CMake cache options and compile-time defaults for postmortem sink selection. |
| SYSLOG(Logging::Shutdown, (_T("WorkerPool snapshot start\n"))); | ||
| SYSLOG(Logging::Shutdown, (_T("[%s]\n"), jsonContent.c_str())); | ||
| SYSLOG(Logging::Shutdown, (_T("WorkerPool snapshot end\n"))); | ||
| fflush(stderr); |
|
Contributor
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
… in a generic path i.e Postmortempath
sebaszm
requested changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces PostMortemDataSink enum (FILE/LOG/ALL/DISABLED) to independently control where WorkerPool JSON snapshots and callstack dumps are written on crash. Defaults: wpSink=FILE, csSink=DISABLED.