Rename extensions directory to addons by nxtum · Pull Request #2163 · rdkcentral/Thunder

nxtum · 2026-06-25T09:44:07Z

No description provided.

nxtum · 2026-07-01T07:52:01Z

WebPlatformForEmbedded/ThunderOnWindows#18

@sebaszm needs to be merged with

rdkcmf-jenkins · 2026-07-01T07:53:27Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: f60c438

Report detail: gist'

Copilot

Pull request overview

This PR introduces a new Source/extras/ subtree (replacing the previous extensions include/build references) and updates build files to consume headers from extras instead of extensions. It also adds several “extras” components (process container backends, warning reporting, hibernate, privileged request example, and local tracer) with corresponding CMake/Visual Studio project integration.

Changes:

Updated multiple Visual Studio projects and Source/CMakeLists.txt to replace extensions include paths/subdirectory with extras.
Added Source/extras/CMakeLists.txt and new extras components: hibernate, localtracer, privilegedrequest, processcontainers, warningreporting.
Updated Thunder runtime include to reference extras/hibernate/hibernate.h.

Reviewed changes

Copilot reviewed 8 out of 69 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Source/ThunderPlugin/comprocess.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/Thunder/PluginServer.cpp	Update hibernate include to `../extras/hibernate/hibernate.h`.
Source/Thunder/bridge.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/plugins/proxystubs.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/plugins/plugins.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/common/common.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/com/com.vcxproj	Switch framework include path from `extensions` to `extras`.
Source/CMakeLists.txt	Replace `add_subdirectory(extensions)` with `add_subdirectory(extras)`.
Source/extras/CMakeLists.txt	Add top-level extras feature toggles and subdirectories.
Source/extras/hibernate/hibernate.h	Add hibernate public API header under `extras`.
Source/extras/hibernate/common/Log.h	Add hibernate logging helper header.
Source/extras/hibernate/CMakeLists.txt	Add hibernate library build/install rules.
Source/extras/hibernate/checkpointserver/CheckpointServer.c	Add checkpoint-server based hibernate implementation.
Source/extras/hibernate/checkpointlib/CheckpointLib.c	Add checkpoint-lib based hibernate implementation skeleton.
Source/extras/localtracer/CMakeLists.txt	Add LocalTracer header-only library packaging and optional example.
Source/extras/localtracer/include/localtracer/localtracer.h	Add LocalTracer implementation header.
Source/extras/localtracer/example/CMakeLists.txt	Add LocalTracer example build/install rules.
Source/extras/localtracer/example/main.cpp	Add LocalTracer example application.
Source/extras/privilegedrequest/CMakeLists.txt	Add PrivilegedRequest header-only library packaging + example.
Source/extras/privilegedrequest/example/CMakeLists.txt	Add fdpassing example build/install rules.
Source/extras/privilegedrequest/example/main.cpp	Add fdpassing example application.
Source/extras/processcontainers/CMakeLists.txt	Add ProcessContainers shared lib with selectable backend implementations.
Source/extras/processcontainers/processcontainers.h	Add ProcessContainers public umbrella header.
Source/extras/processcontainers/Module.h	Add ProcessContainers module header.
Source/extras/processcontainers/Module.cpp	Add ProcessContainers module declaration TU.
Source/extras/processcontainers/Messaging.h	Add ProcessContainers tracing category definitions.
Source/extras/processcontainers/IProcessContainers.h	Add ProcessContainers interfaces (containers, producers, iterators).
Source/extras/processcontainers/ContainerProducer.h	Add producer registration helper.
Source/extras/processcontainers/ContainerAdministrator.h	Add runtime selection + container registry API.
Source/extras/processcontainers/ContainerAdministrator.cpp	Implement runtime initialization/selection and container creation.
Source/extras/processcontainers/common/BaseRefCount.h	Add ref-counted base for ProcessContainers helper interfaces.
Source/extras/processcontainers/common/BaseContainerIterator.h	Add container ID iterator implementation.
Source/extras/processcontainers/common/CGroupContainerInfo.h	Add cgroup-based Memory/CPU metrics helper implementation.
Source/extras/processcontainers/implementations/RunCImplementation/CMakeLists.txt	Add RunC backend build rules.
Source/extras/processcontainers/implementations/RunCImplementation/RunCImplementation.h	Add RunC backend API/impl declarations.
Source/extras/processcontainers/implementations/RunCImplementation/RunCImplementation.cpp	Add RunC backend implementation.
Source/extras/processcontainers/implementations/LXCImplementation/CMakeLists.txt	Add LXC backend build rules.
Source/extras/processcontainers/implementations/LXCImplementation/LXCImplementation.h	Add LXC backend API/impl declarations.
Source/extras/processcontainers/implementations/DobbyImplementation/CMakeLists.txt	Add Dobby backend build rules.
Source/extras/processcontainers/implementations/DobbyImplementation/DobbyImplementation.h	Add Dobby backend API/impl declarations.
Source/extras/processcontainers/implementations/DobbyImplementation/DobbyImplementation.cpp	Add Dobby backend implementation.
Source/extras/processcontainers/implementations/CRunImplementation/CMakeLists.txt	Add CRun backend build rules.
Source/extras/processcontainers/implementations/CRunImplementation/CRunImplementation.h	Add CRun backend API/impl declarations.
Source/extras/processcontainers/implementations/CRunImplementation/CRunImplementation.cpp	Add CRun backend implementation.
Source/extras/processcontainers/implementations/AWCImplementation/CMakeLists.txt	Add AWC backend build rules.
Source/extras/processcontainers/implementations/AWCImplementation/AWC.h	Add AWC backend helper types.
Source/extras/processcontainers/implementations/AWCImplementation/AWC.cpp	Implement AWC state-change notifier.
Source/extras/processcontainers/implementations/AWCImplementation/AWCImplementation.h	Add direct AWC container implementation declaration.
Source/extras/processcontainers/implementations/AWCImplementation/AWCImplementation.cpp	Add direct AWC container implementation.
Source/extras/processcontainers/implementations/AWCImplementation/AWCContainerBase.h	Add AWC container base class declaration.
Source/extras/processcontainers/implementations/AWCImplementation/AWCContainerBase.cpp	Add AWC container base class implementation.
Source/extras/processcontainers/implementations/AWCImplementation/AWCProxyContainer.h	Add DBus proxy-based AWC container declaration.
Source/extras/processcontainers/implementations/AWCImplementation/AWCProxyContainer.cpp	Add DBus proxy-based AWC container implementation.
Source/extras/processcontainers/implementations/AWCImplementation/AWCContainerAdministrator.h	Add AWC container producer declaration and JSON config parser.
Source/extras/processcontainers/implementations/AWCImplementation/AWCContainerAdministrator.cpp	Add AWC producer implementation and backend selection logic.
Source/extras/processcontainers/implementations/AWCImplementation/dbus/api.xml	Add DBus interface definition for container control.
Source/extras/processcontainers/implementations/AWCImplementation/dbus/Client.h	Add DBus client wrapper declaration.
Source/extras/processcontainers/implementations/AWCImplementation/dbus/Client.cpp	Add DBus client wrapper implementation.
Source/extras/warningreporting/CMakeLists.txt	Add WarningReporting library build/install rules.
Source/extras/warningreporting/Module.h	Add WarningReporting module header.
Source/extras/warningreporting/Module.cpp	Add WarningReporting module declaration TU.
Source/extras/warningreporting/warningreporting.h	Add WarningReporting public umbrella header.
Source/extras/warningreporting/IWarningReportingMedia.h	Add WarningReporting media output interface.
Source/extras/warningreporting/WarningReportingUnit.h	Add WarningReportingUnit declaration and JSON helpers.
Source/extras/warningreporting/WarningReportingUnit.cpp	Add WarningReportingUnit implementation.
Source/extras/warningreporting/warningreporting.vcxproj	Add/adjust VS project for WarningReporting.
Source/extras/warningreporting/warningreporting.vcxproj.filters	Add VS filters file for WarningReporting.

…to renameThunderExtensions

rdkcmf-jenkins · 2026-07-01T10:46:21Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: f60c438

Report detail: gist'

mhughesacn · 2026-07-01T11:27:43Z

Hi @nxtum : Appreciate that this is existing code, but please will you modify NOTICE at top level, where it says:
"Files under the implementations directory are" to say:
"Files under the implementations directory (and other changes as indicated) are:"
Thank you.

rdkcmf-jenkins · 2026-07-02T07:57:13Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: ef80117

Report detail: gist'

rdkcmf-jenkins · 2026-07-02T07:58:35Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: 08b6246

Report detail: gist'

nxtum · 2026-07-02T08:01:09Z

Hi @nxtum : Appreciate that this is existing code, but please will you modify NOTICE at top level, where it says: "Files under the implementations directory are" to say: "Files under the implementations directory (and other changes as indicated) are:" Thank you.

Hello,

I have edited the file as requested

Copilot

Pull request overview

Copilot reviewed 9 out of 70 changed files in this pull request and generated 2 comments.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

rdkcmf-jenkins · 2026-07-02T08:36:48Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: abb89a0

Report detail: gist'

github-actions · 2026-07-02T08:37:09Z

PR Preview Action v1.1.1-25-g59e77e4
🛫 Deployed preview to https://rdkcentral.github.io/Thunder/pr-preview/pr-2163/
on branch `gh-pages` at 2026-07-06 10:03 UTC

rdkcmf-jenkins · 2026-07-02T08:38:03Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: abb89a0

Report detail: gist'

…nderExtensions

…to renameThunderExtensions

rdkcmf-jenkins · 2026-07-02T09:13:10Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: 56e483b

Report detail: gist'

rdkcmf-jenkins · 2026-07-02T10:38:19Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/Thunder/2163/rdkcentral/Thunder
Commit: 56e483b

Report detail: gist'

rdkcmf-jenkins · 2026-07-02T10:44:37Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Thank you
Commit: 56e483b
'

sebaszm

Watch out for the new real extensions paths!

…nderExtensions

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

nxtum added 4 commits June 25, 2026 01:06

extensions into extras

6ea4b65

warningreporting

9ebd7ce

test explicit...

70eb189

not working warning reporting

f60c438

nxtum marked this pull request as ready for review July 1, 2026 07:51

Copilot AI review requested due to automatic review settings July 1, 2026 07:51

Copilot started reviewing on behalf of nxtum July 1, 2026 07:52 View session

nxtum requested a review from sebaszm July 1, 2026 07:52

Copilot AI reviewed Jul 1, 2026

View reviewed changes

nxtum added 2 commits July 1, 2026 01:41

addons

69fe342

Merge branch 'renameThunderExtensions' of github.com:nxtum/Thunder in…

ef80117

…to renameThunderExtensions

Merge branch 'master' into renameThunderExtensions

08b6246

Copilot AI review requested due to automatic review settings July 2, 2026 07:57

Copilot started reviewing on behalf of nxtum July 2, 2026 07:59 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread Source/CMakeLists.txt

Comment thread Source/Thunder/PluginServer.cpp

nxtum changed the title ~~Rename extensions directory to extras~~ Rename extensions directory to addons Jul 2, 2026

nxtum and others added 2 commits July 2, 2026 01:35

change hardcoded extensions paths

6a8ef55

Merge branch 'master' into renameThunderExtensions

abb89a0

Copilot AI review requested due to automatic review settings July 2, 2026 08:36

Copilot AI reviewed Jul 2, 2026

nxtum added 3 commits July 2, 2026 02:02

Merge branch 'master' of github.com:rdkcentral/Thunder into renameThu…

a70347b

…nderExtensions

adjust new tests

d02f32a

Merge branch 'renameThunderExtensions' of github.com:nxtum/Thunder in…

56e483b

…to renameThunderExtensions

sebaszm requested changes Jul 2, 2026

View reviewed changes

Comment thread Source/Thunder/GenericConfig.cmake Outdated

Comment thread Source/Thunder/PluginServer.cpp Outdated

Comment thread Source/Thunder/PluginServer.h Outdated

nxtum added 2 commits July 6, 2026 02:59

Merge branch 'master' of github.com:rdkcentral/Thunder into renameThu…

817eaae

…nderExtensions

revert some wrong ones

629f418

Copilot AI review requested due to automatic review settings July 6, 2026 10:02

Copilot AI reviewed Jul 6, 2026

nxtum requested a review from sebaszm July 6, 2026 10:04

sebaszm approved these changes Jul 6, 2026

View reviewed changes

sebaszm merged commit 818f318 into rdkcentral:master Jul 6, 2026
91 of 95 checks passed

github-actions Bot locked and limited conversation to collaborators Jul 6, 2026

nxtum deleted the renameThunderExtensions branch July 6, 2026 13:08

Uh oh!

Conversation

nxtum commented Jun 25, 2026

Uh oh!

nxtum commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

rdkcmf-jenkins commented Jul 1, 2026

Uh oh!

mhughesacn commented Jul 1, 2026

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

nxtum commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

rdkcmf-jenkins commented Jul 2, 2026

Uh oh!

sebaszm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nxtum commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 2, 2026 •

edited

Loading