Skip to content

fix: handle in/notin operators in token search filters #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohilsurana wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: handle in/notin operators in token search filters #1656

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aadd5b
fix: handle in/notin operators in token search filters
rohilsurana May 27, 2026
3aba0ed
fix: trim and sanitize in/notin filter values
rohilsurana May 27, 2026
a26e497
refactor: fold in/notin filter cases into single branch
rohilsurana May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions internal/store/postgres/org_tokens_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"database/sql"
"fmt"
"strings"

"github.com/doug-martin/goqu/v9"
"github.com/jmoiron/sqlx"
Expand Down Expand Up @@ -166,6 +167,22 @@ func (r OrgTokensRepository) addFilter(query *goqu.SelectDataset, filter rql.Fil
case "like", "notlike":
value := "%" + filter.Value.(string) + "%"
return query.Where(goqu.Ex{field: goqu.Op{filter.Operator: value}}), nil
case "in":
values := make([]string, 0)
for _, v := range strings.Split(filter.Value.(string), ",") {
if trimmed := strings.TrimSpace(v); trimmed != "" {
values = append(values, trimmed)
}
}
return query.Where(goqu.Cast(goqu.I(field), "TEXT").In(values)), nil
case "notin":
values := make([]string, 0)
for _, v := range strings.Split(filter.Value.(string), ",") {
if trimmed := strings.TrimSpace(v); trimmed != "" {
values = append(values, trimmed)
}
}
return query.Where(goqu.Cast(goqu.I(field), "TEXT").NotIn(values)), nil
Comment thread
AmanGIT07 marked this conversation as resolved.
Outdated
default:
return query.Where(goqu.Ex{field: goqu.Op{filter.Operator: filter.Value}}), nil
}
Expand Down
Loading