Skip to content

[REVIEW] Drop extra copy in get_last_error_text #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakirkham wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −5
Open

[REVIEW] Drop extra copy in get_last_error_text #2044

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bf92c0
Drop extra copy in `get_last_error_text`
jakirkham Apr 29, 2026
f4e7894
Drop empty `return` in `get_last_error_text`
jakirkham Apr 29, 2026
243e4e1
Update year to 2026
jakirkham Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions python/cuvs/cuvs/common/exceptions.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# SPDX-FileCopyrightText: Copyright (c) 2024, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0
#
# cython: language_level=3
Expand All @@ -14,10 +14,8 @@ class CuvsException(Exception):
def get_last_error_text():
""" returns the last error description from the cuvs c-api """
cdef const char* c_err = cuvsGetLastErrorText()
if c_err is NULL:
return
cdef bytes err = c_err
return err.decode("utf8", "ignore")
if c_err is not NULL:
return c_err.decode("utf8", "ignore")


def check_cuvs(status: cuvsError_t):
Expand Down
Loading