Skip to content

Remove inertia_check Param from KMeans #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
Apr 30, 2026
+4 −8
Merged

Remove inertia_check Param from KMeans #8033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e72fc35
rm inertia param
tarang-jain Apr 29, 2026
8e57a4b
fix copyright
tarang-jain Apr 29, 2026
90060ad
Merge branch 'main' into rm-inertia-check
tarang-jain Apr 29, 2026
535edd8
Merge branch 'main' into rm-inertia-check
tarang-jain Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/bench/sg/kmeans.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -95,7 +95,6 @@ std::vector<Params> getInputs()
p.kmeans.verbosity = rapids_logger::level_enum::info;
p.kmeans.metric = ML::distance::DistanceType::L2Expanded;
p.kmeans.rng_state = raft::random::RngState(p.blobs.seed);
p.kmeans.inertia_check = true;
std::vector<std::pair<int, int>> rowcols = {
{160000, 64},
{320000, 64},
Expand Down
1 change: 0 additions & 1 deletion cpp/include/cuml/cluster/kmeans_params.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ struct KMeansParams {
double oversampling_factor = 2.0;
int batch_samples = 1 << 15;
int batch_centroids = 0;
bool inertia_check = false;

cuvs::cluster::kmeans::params to_cuvs() const;
};
Expand Down
3 changes: 1 addition & 2 deletions cpp/src/kmeans/kmeans_params.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -25,7 +25,6 @@ cuvs::cluster::kmeans::params KMeansParams::to_cuvs() const
params.oversampling_factor = this->oversampling_factor;
params.batch_samples = this->batch_samples;
params.batch_centroids = this->batch_centroids;
params.inertia_check = this->inertia_check;

return params;
}
Expand Down
5 changes: 2 additions & 3 deletions python/cuml/cuml/cluster/cpp/kmeans.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0
#

Expand Down Expand Up @@ -29,8 +29,7 @@ cdef extern from "cuml/cluster/kmeans_params.hpp" namespace "ML::kmeans" nogil:
int n_init,
double oversampling_factor,
int batch_samples,
int batch_centroids,
bool inertia_check
int batch_centroids


cdef extern from "cuml/cluster/kmeans.hpp" namespace "ML::kmeans" nogil:
Expand Down
Loading