Add Kerberos ticket trace verbosity levels#21568
Open
eve0805 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! As part of our landing process, we manually verify that all modules work as expected. We've added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR builds on #21466 by adding a
KerberosTicketTraceLeveloption for Kerberos ticket tracing.The new option controls how much Kerberos trace detail is printed when
KerberosTicketTraceis enabled.Trace Levels
KerberosTicketTraceLevelsupports three modes:meta: prints high-level metadata and avoids expanding binary ticket or encrypted payload contentsticket: prints ticket-oriented trace output while still redacting raw binary payload contentsfull: preserves the existing verbose behavior and expands binary fields as hexThe default value is
full, so existingKerberosTicketTracebehavior remains unchanged unless users explicitly choose a lower verbosity level.Changes
KerberosTicketTraceLevelas anOptEnumwithmeta,ticket, andfullmetafulltrace levelsTesting
bundle exec rspec spec/lib/msf/core/exploit/remote/kerberos/client_spec.rbbundle exec rspec spec/lib/rex/proto/kerberos/kerberos_logger_subscriber_spec.rbbundle exec rspec spec/lib/msf/base/serializer/readable_text_spec.rbbundle exec rubocop lib/msf/core/exploit/remote/kerberos/client.rb lib/msf/core/exploit/remote/kerberos/service_authenticator/options.rb lib/rex/proto/kerberos/kerberos_logger_subscriber.rb spec/lib/msf/base/serializer/readable_text_spec.rb spec/lib/msf/core/exploit/remote/kerberos/client_spec.rb spec/lib/rex/proto/kerberos/kerberos_logger_subscriber_spec.rb