Adds fail-safe for search fileless fetch payloads and updates the docs accordingly#21548
Open
msutovsky-r7 wants to merge 2 commits into
Open
Adds fail-safe for search fileless fetch payloads and updates the docs accordingly#21548msutovsky-r7 wants to merge 2 commits into
msutovsky-r7 wants to merge 2 commits into
Conversation
dwelch-r7
reviewed
Jun 12, 2026
| cmd << '; then $f' | ||
| cmd << '; FOUND=1' | ||
| cmd << '; break' | ||
| cmd << '; exit 1' |
Contributor
There was a problem hiding this comment.
what's the reason for this change here?
Contributor
Author
There was a problem hiding this comment.
When the shell-search fails, it should exit the loop and execute the fail-safe fetch command. If there would be only break and shell-search would succeed, it would execute fail-safe regardless. To avoid too much of additional code, the shell-search exits when executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shell-searchvariant of fileless fetch payloads has been proved to be not fully reliable across all systems as there are systems (dockers, fresh systems with low resources, access as very low-privileged user,..) where the anonymous file handles either don't exist or existing user does not have permission to write the payload into them. This PR mentions this in fetch payload documentation and adds fail-safe mechanism, which defaults to standard fetch payload if no available file handle is found.