feat(exercise-world): package Nacre and seed MISP - #211
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c6a932394
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /provisioning/provision-users.sh | ||
| /provisioning/provision-warninglists.sh | ||
| /provisioning/provision-content.sh | ||
| python3 /provisioning/verify-exercise-world.py |
There was a problem hiding this comment.
Refresh persisted galaxy files before verification
When upgrading an existing Compose deployment, the misp-files named volume mounted over /var/www/MISP/app/files in docker-compose.yml:71-73 retains the previous v2.5.37 contents and masks the v2.5.44 files checked during the image build. Consequently, provision-content.sh:64-65 imports the old bundled galaxies and this newly mandatory verifier exits before sample-event provisioning because Nacre is absent. Copy or synchronize the new bundled galaxy data into the persistent volume before updating and verifying it.
Useful? React with 👍 / 👎.
| {"name": "misp-galaxy:exercise-world=\"Asterin Union\""}, | ||
| {"name": "misp-galaxy:exercise-world=\"NovaCore Systems\""}, | ||
| {"name": "misp-galaxy:exercise-world=\"TA-700 Obsidian Jackal\""} |
There was a problem hiding this comment.
Update existing sample events instead of skipping them
For deployments where these sample-event UUIDs were imported before this upgrade, provision-sample-events.sh:65-67 detects each existing event and skips it, so none of the newly added Nacre tags are applied. The seeding change therefore only works on fresh databases; the provisioner needs to patch or replace existing fixtures when their contents change.
Useful? React with 👍 / 👎.
|
Addressed both Codex review findings in
Validation: 9 unit tests, generated-index check, shell/Python syntax, JSON validation, Compose config, Docker build check, and whitespace check all pass. |
Summary
05_world_layer/with byte-identical Nacre galaxy/cluster snapshots, CC-BY-4.0 attribution, provenance and generated lookup indexesv2.5.37tov2.5.44, the current approved upstream release candidate for this changeWhy the exact hash check matters
MISP and non-MISP consumers must use the same entity revision. UUID/count checks alone would not detect metadata or entity substitutions that preserve the count, so the Docker build ties MISP's bundled files to the vendored snapshot hashes.
Validation
python3 -m unittest 05_world_layer/tests/test_nacre_world.py -v— 7 tests passpython3 05_world_layer/tools/generate_indexes.py --checkbash -non all MISP provisioning scriptsjq emptyon manifests, world data, indexes and MISP event fixturesdocker compose ... config --quietdocker build --check -f Dockerfile .— no warnings55afe65a817c167a46dbd26850515aefb2bf72b9318f651d6adb172e498a44b4f1fe9a26eae4148542e0d89126cdf4231c803b2c3fd255137b42e2c5f969807aA full MISP image build/deployment is intentionally left for integration testing because it builds MISP and dependencies from source.
Refs #210
Related: range42/project_management#106