Fixing Appco fleet and neuvector failing tests#743
Conversation
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. |
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
1 similar comment
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
4858d21 to
233d17b
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
233d17b to
3b0458d
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
khushboo-rancher
left a comment
khushboo-rancher
left a comment
There was a problem hiding this comment.
LGTM, qq to understand this - Why are we moving from token to admin-password?
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
3b0458d to
5c936ca
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
floatingman
left a comment
floatingman
left a comment
There was a problem hiding this comment.
Looks good. Are you going to create a JJB PR as well?
@khushboo-rancher Token is also used; the bootstrap password is just used for the initial Rancher install, and the admin password is used if someone wants to log in and check the cluster manually. I think all of the tests still use a token to run. |
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
5c936ca to
f89e23c
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
f89e23c to
3c0c7d7
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. TestNodeDriver |
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
3c0c7d7 to
5804471
Compare
|
NeuVectorTestSuite TestNeuVectorInstallation TestSuites above were modified. TestSuites below use modified code from this PR. |
| def libraryBranch = env.QA_JENKINS_LIBRARY_BRANCH ?: 'main' | ||
| library "qa-jenkins-library@${libraryBranch}" | ||
|
|
||
| def DEFAULT_RANCHER_PASSWORD = 'XRi&Vfw8_Qr7*YVh1DE' |
There was a problem hiding this comment.
what is this supposed to fix exactly?
and is it ok for us to include this in plain text on a public repo? (not sure but maybe it is)
There was a problem hiding this comment.
I agree. It's probably best to put this in the JJB repo.
There was a problem hiding this comment.
The default parameter value in the declarative Jenkinsfile is overriding the default value configured in JJB
There was a problem hiding this comment.
It is fixing the "Password must be at least 12 characters" rancher validation
There was a problem hiding this comment.
Oh so the problem here is that the default "rancherrocks" is invalid. It does have 12 characters, could it be that the problem is that it only contains small-case letters?
EIther way I agree with @floatingman and this should probably live over on JJB repo.
There was a problem hiding this comment.
As I mentioned, the declarative Jenkins pipeline in rancher/tests overrides the parameters configured in the JJB repository
There was a problem hiding this comment.
@lscalabrini01 This password shouldn't be used in a public repository, because it is used elsewhere.
There was a problem hiding this comment.
Either change it to something that isn't used elsewhere or use another password.
| def libraryBranch = env.QA_JENKINS_LIBRARY_BRANCH ?: 'main' | ||
| library "qa-jenkins-library@${libraryBranch}" | ||
|
|
||
| def DEFAULT_RANCHER_PASSWORD = 'XRi&Vfw8_Qr7*YVh1DE' |
There was a problem hiding this comment.
Either change it to something that isn't used elsewhere or use another password.
lscalabrini01
force-pushed
the
qa-qase-fix_440
branch
from
5804471 to
d5d563e
Compare
4 participants
No description provided.