Skip to content

Modify project/namespace helper functions for cluster member #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joesims22 merged 1 commit into from
Feb 13, 2026
Merged

Modify project/namespace helper functions for cluster member #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions actions/rbac/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,22 @@ func VerifyUserCanGetProject(t *testing.T, client, standardClient *rancher.Clien
}

// VerifyUserCanCreateProjects validates a user with the required cluster permissions are able/not able to create projects in the downstream cluster
func VerifyUserCanCreateProjects(t *testing.T, client, standardClient *rancher.Client, clusterID string, role Role) {
memberProject, err := projectapi.CreateProject(standardClient, clusterID)
switch role {
case ClusterOwner, ClusterMember:
require.NoError(t, err)
log.Info("Created project as a ", role, " is ", memberProject.Name)
case ProjectOwner, ProjectMember:
require.Error(t, err)
assert.True(t, apierrors.IsForbidden(err))
}
func VerifyUserCanCreateProjects(t *testing.T, client, standardClient *rancher.Client, standardUser *management.User, clusterID string, role Role) {
projectTemplate := projectapi.NewProjectTemplate(clusterID)
if role.String() == ClusterMember.String() {
projectTemplate.Annotations = map[string]string{
"field.cattle.io/creatorId": standardUser.ID,
}
}
memberProject, err := standardClient.WranglerContext.Mgmt.Project().Create(projectTemplate)
switch role {
case ClusterOwner, ClusterMember:
require.NoError(t, err)
log.Info("Created project as a ", role, " is ", memberProject.Name)
case ProjectOwner, ProjectMember:
require.Error(t, err)
assert.True(t, apierrors.IsForbidden(err))
}
}

// VerifyUserCanCreateNamespace validates a user with the required cluster permissions are able/not able to create namespaces in the project they do not own
Expand All @@ -129,7 +135,9 @@ func VerifyUserCanCreateNamespace(t *testing.T, client, standardClient *rancher.
assert.Equal(t, ActiveStatus, strings.ToLower(actualStatus))
case ClusterMember:
require.Error(t, checkErr)
assert.True(t, apierrors.IsForbidden(checkErr))
statusErr, ok := checkErr.(*apierrors.StatusError)
require.True(t, ok, "expected error to be a StatusError")
assert.Equal(t, int32(403), statusErr.ErrStatus.Code)
}
}

Expand Down
2 changes: 1 addition & 1 deletion validation/rbac/rbac_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (rb *RBTestSuite) sequentialTestRBAC(role rbac.Role, member string, user *m
rbac.VerifyUserCanGetProject(rb.T(), rb.client, standardClient, rb.cluster.ID, adminProject.Name, role)
})
rb.Run("Validating if members with role "+role.String()+" is able to create a project in the cluster", func() {
rbac.VerifyUserCanCreateProjects(rb.T(), rb.client, standardClient, rb.cluster.ID, role)
rbac.VerifyUserCanCreateProjects(rb.T(), rb.client, standardClient, user, rb.cluster.ID, role)
})
rb.Run("Validating if "+role.String()+" can lists all namespaces in a cluster.", func() {
rbac.VerifyUserCanListNamespace(rb.T(), rb.client, standardClient, adminProject, rb.cluster.ID, role)
Expand Down