Skip to content

Fix Yandex translator #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
no1d wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Yandex translator #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Translumo.Infrastructure/Constants/RegexStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Text.RegularExpressions;
using System.Text.RegularExpressions;

namespace Translumo.Infrastructure.Constants
{
Expand Down Expand Up @@ -28,7 +28,7 @@ static RegexStorage()
EndDotRegex = new Regex(@"\.{3,}$", RegexOptions.Compiled);
GoogleTranslateResultRegex = new Regex("(?<=(<div(.*)class=\"result-container\"(.*)>))[\\s\\S]*?(?=(<\\/div>))", RegexOptions.Compiled | RegexOptions.IgnoreCase);
GuidGenerationRegex = new Regex("[xy]", RegexOptions.Compiled);
YandexSidRegex = new Regex(@"(?<=(SID\:\s*')).*(?=('))", RegexOptions.Compiled);
YandexSidRegex = new Regex(@"(?<=(sid\:\s*')).*(?=('))", RegexOptions.Compiled | RegexOptions.IgnoreCase);
DeeplSentenceRegex = new Regex(@"(\S.+?([.!?♪。]|$))([\r\n]+|(?=\s+|$))", RegexOptions.Compiled | RegexOptions.Multiline);
}
}
Expand Down
10 changes: 2 additions & 8 deletions src/Translumo.Translation/Yandex/YandexReaderProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Linq;
using System.Net.Http;
using System.Text.Json;
Expand Down Expand Up @@ -61,16 +61,10 @@ public string ExtractSid(string body)
return string.Empty;
}

const char SID_SEPARATOR = '.';

var match = RegexStorage.YandexSidRegex.Match(body);
if (match.Success)
{
var splittedReversed = match.Value
.Split(SID_SEPARATOR)
.Select(str => new string(str.Reverse().ToArray()));

return string.Join(SID_SEPARATOR, splittedReversed);
return match.Value;
}

return string.Empty;
Expand Down