Skip to content

DSEGOG-553 configurable default channels - #907

Merged
louise-davies merged 5 commits into
developfrom
DSEGOG-553-configurable-default-channels
Aug 7, 2026
Merged

DSEGOG-553 configurable default channels#907
louise-davies merged 5 commits into
developfrom
DSEGOG-553-configurable-default-channels

Conversation

@louise-davies

@louise-davies louise-davies commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

Add initialChannels config to settings, and this controls:

  • which channels are loaded in the table by default
  • if a default channel is removable
  • if a default channel is sticky

These three functionalities cover both the requested EPAC behaviour (sticky, non-removable time channel which is still the default), and means that if we want we can replicate eCAT (time and shotnum as initial channels, both removable and non-sticky)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Try some different initial channels config, test that the removable & sticky behaviour work correctly

Agile board tracking

Closes DSEGOG-553

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.67%. Comparing base (49da776) to head (dc39b67).
⚠️ Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
src/state/slices/configSlice.tsx 90.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
+ Coverage    96.42%   96.67%   +0.25%     
===========================================
  Files          107      108       +1     
  Lines         5396     5506     +110     
  Branches      1568     1611      +43     
===========================================
+ Hits          5203     5323     +120     
+ Misses         186      174      -12     
- Partials         7        9       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@louise-davies
louise-davies force-pushed the DSEGOG-553-configurable-default-channels branch from 81850e5 to dc39b67 Compare August 7, 2026 08:38

@joshdimanteto joshdimanteto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, tested the sticky and removable functionality. One thing i noticed was that if we have old sessions, it is not going to have the new order.

@louise-davies

Copy link
Copy Markdown
Member Author

@joshdimanteto for EPAC we won't be changing the config, and for Gemini it's not really being used yet I don't think, plus I think they want them to be deletable anyway so them having sessions without it is fine

@joshdimanteto
joshdimanteto self-requested a review August 7, 2026 09:19

@joshdimanteto joshdimanteto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louise-davies
louise-davies merged commit 35d1a08 into develop Aug 7, 2026
11 of 14 checks passed
@louise-davies
louise-davies deleted the DSEGOG-553-configurable-default-channels branch August 7, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants