DSEGOG-553 configurable default channels - #907
Merged
Merged
Conversation
…tions called in `configureApp` to extraReducers in their respective slices
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #907 +/- ##
===========================================
+ Coverage 96.42% 96.67% +0.25%
===========================================
Files 107 108 +1
Lines 5396 5506 +110
Branches 1568 1611 +43
===========================================
+ Hits 5203 5323 +120
+ Misses 186 174 -12
- Partials 7 9 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
louise-davies
force-pushed
the
DSEGOG-553-configurable-default-channels
branch
from
August 7, 2026 08:38
81850e5 to
dc39b67
Compare
joshdimanteto
left a comment
Contributor
There was a problem hiding this comment.
Works well, tested the sticky and removable functionality. One thing i noticed was that if we have old sessions, it is not going to have the new order.
Member
Author
|
@joshdimanteto for EPAC we won't be changing the config, and for Gemini it's not really being used yet I don't think, plus I think they want them to be deletable anyway so them having sessions without it is fine |
joshdimanteto
self-requested a review
August 7, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
initialChannelsconfig to settings, and this controls:These three functionalities cover both the requested EPAC behaviour (sticky, non-removable time channel which is still the default), and means that if we want we can replicate eCAT (time and shotnum as initial channels, both removable and non-sticky)
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes DSEGOG-553