Allow list elements to be translatable and left align data policy text - #1986
Open
louise-davies wants to merge 1 commit into
Open
Allow list elements to be translatable and left align data policy text#1986louise-davies wants to merge 1 commit into
louise-davies wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1986 +/- ##
========================================
Coverage 96.72% 96.73%
========================================
Files 221 221
Lines 31463 31475 +12
Branches 4751 4751
========================================
+ Hits 30434 30446 +12
+ Misses 1025 1024 -1
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title. The data policy text I got from Silvia had a bullet-point list, so configuring i18next so we can render html lists properly, and then the data policy looked weird when it was middle aligned, so left aligned the data policies.
To test this, replace the
data_policystring inpublic/res/default.jsonin datagateway-download to something like:and then go to the cart and pretend to mint a user-defined DOI and check that the data policy is rendering the list correctly and that it is left aligned.
There's also the data policy in the publish button, but the code is identical so probably don't need to double check both
Testing instructions
Add a set up instructions describing how the reviewer should test the code