Skip to content

Add Is PI button switch for My DOIs table - #1970

Open
xkyue wants to merge 8 commits into
developfrom
enhancement/add-PI-button#1956
Open

Add Is PI button switch for My DOIs table#1970
xkyue wants to merge 8 commits into
developfrom
enhancement/add-PI-button#1956

Conversation

@xkyue

@xkyue xkyue commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the existing option minter, and instead have a separate toggle for PI/Any which can be used to filter both user defined and session DOIs. Then we should probably reword/rename the remaining options in the my doi page to just be User-Defined/Session DOI and change the label wording to match what the All DOI table uses (this language will be simpler and more intuitive as well)

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes to #1956

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.74074% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.53%. Comparing base (d87046a) to head (dd3fb7e).
⚠️ Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
...iew/src/views/table/dls/dlsDOITables.component.tsx 14.75% 52 Missing ⚠️
...y-dataview/src/views/doiTypeSelector.component.tsx 73.91% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1970      +/-   ##
===========================================
- Coverage    96.72%   96.53%   -0.20%     
===========================================
  Files          221      221              
  Lines        31463    31552      +89     
  Branches      4751     4768      +17     
===========================================
+ Hits         30434    30458      +24     
- Misses        1025     1089      +64     
- Partials         4        5       +1     
Flag Coverage Δ
common 95.48% <100.00%> (-0.01%) ⬇️
dataview 97.94% <40.18%> (-0.57%) ⬇️
download 96.87% <ø> (ø)
search 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/datagateway-dataview/src/views/doiTypeSelector.component.tsx Outdated
Comment thread packages/datagateway-dataview/public/res/default.json Outdated
@xkyue xkyue self-assigned this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants