-
Notifications
You must be signed in to change notification settings - Fork 13
raincatcher-file enhancements #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5c7b20f
add queue module, fileSystem module, fixed eslint errors after runnin…
col1985 5ade86e
convert CRUD ops to promises
col1985 d30152a
Merge branch 'feature-queue'
col1985 38a15f1
add fs module to fileClient object
col1985 e3a6fd5
add else conditional to fileSystem ready check, remove fileError from…
col1985 8f0ea5b
PR feedback, fileSystem enhancements, persist queue via file system
col1985 6a74ddb
implement download queue, updated readme, added basic unit tests
col1985 2c60e8d
set fileContent type from config, add save queues fn to fileClient, u…
col1985 f33a2a2
Merge branch 'feature-pr-feedback'
col1985 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| node_modules | ||
| npm-debug.log | ||
| .idea | ||
| .vscode | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,15 @@ | ||
| 'use strict'; | ||
| // 'use strict'; | ||
|
|
||
| module.exports = { | ||
| apiHost: 'http://localhost:8080', | ||
| apiPath: '/file/wfm', | ||
| cloudDataTopicPrefix: 'wfm:cloud:data:', | ||
| datasetId: 'file' | ||
| }; | ||
| datasetId: 'file', | ||
| queue: { | ||
| prefix: 'fh.wfm.file.queue.', | ||
| storageType: 'localStorage', | ||
| uploadsLabel: 'uploads', | ||
| downloadsLabel: 'downloads', | ||
| fileContentType: 'application/json' | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this function called from? It it called from the application consuming the module?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the intention is to call this function from the app.js or where ever the developer would prefer. There is also an expectation the developer will handle offline and online events, saving and processing the queue as needed.
I will update README detailing this. What do you think?