Update active_model_serializers.gemspec#2452
Closed
kalashnikovisme wants to merge 1 commit intorails-api:0-10-stablefrom
Closed
Update active_model_serializers.gemspec#2452kalashnikovisme wants to merge 1 commit intorails-api:0-10-stablefrom
kalashnikovisme wants to merge 1 commit intorails-api:0-10-stablefrom
Conversation
Member
|
Thank you @kalashnikovisme for your PR! Also great to hear that your test suite is happy with the change. Still if you don't mind, can we close this in favor of #2453 ? |
Author
|
@wasifhossain oh, of course! I had not found that one, so created mine 😄 |
Member
|
you are right, because the other one was created after yours, but with the updated test matrix 😅 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To use this gem with Rails 7.1.0 project.
Changes
Upgrade
rails_versionsin dependenciesAdditional helpful information
All tests (around 500) are passed in our projects.