Skip to content

[2/7][multi-lora]: adapter controller - registry state machine, backend, control-plane HTTP API, named Ray actor#1743

Merged
yushengsu-thu merged 4 commits into
radixark:mainfrom
mathewjhan:multi-lora/02-controller
Jul 21, 2026
Merged

[2/7][multi-lora]: adapter controller - registry state machine, backend, control-plane HTTP API, named Ray actor#1743
yushengsu-thu merged 4 commits into
radixark:mainfrom
mathewjhan:multi-lora/02-controller

Conversation

@mathewjhan

@mathewjhan mathewjhan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a multi-LoRA training framework, implementing a controller Ray actor, an HTTP control-plane server, an adapter registry, and configuration parsing to manage the lifecycle of concurrent LoRA adapters. The code review identified several critical issues and improvement opportunities: a potential stale actor handle caching bug in the controller, possible crashes in the HTTP server when handling null configurations or malformed YAML files, silent validation bypasses for empty data paths, the risky use of assert statements for production argument validation, and unnecessarily long timeouts on time-sensitive abort requests.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread miles/ray/multi_lora/controller.py
Comment thread miles/ray/multi_lora/http_server.py
Comment thread miles/ray/multi_lora/backend.py
Comment thread miles/utils/multi_lora.py
Comment thread miles/ray/multi_lora/backend.py
Comment thread miles/utils/adapter_config.py
@mathewjhan mathewjhan changed the title [2/7][multi-lora]: adapter controller -registry state machine, backend, control-plane HTTP API, named Ray actor [2/7][multi-lora]: adapter controller - registry state machine, backend, control-plane HTTP API, named Ray actor Jul 21, 2026

@yushengsu-thu yushengsu-thu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed extensively on the umbrella PR #1638 (2xH200 E2E validated); layer verified independently (imports + fast suites green on this branch's own tree).

@yushengsu-thu
yushengsu-thu merged commit a80fe33 into radixark:main Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants